From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewi6E-0005fI-SY for qemu-devel@nongnu.org; Fri, 16 Mar 2018 01:40:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewi6E-0003Ft-18 for qemu-devel@nongnu.org; Fri, 16 Mar 2018 01:40:18 -0400 From: Thomas Huth Date: Fri, 16 Mar 2018 06:39:52 +0100 Message-Id: <1521178795-21894-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Victor Kaplansky , "Michael S. Tsirkin" , qemu-block@nongnu.org, qemu-s390x@nongnu.org, Peter Maydell , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Mark Cave-Ayland , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eric Blake , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=3Dscsi") on a couple of boards, since there was no error detected during the "make check" regression testing. This is clearly an indication that we are lacking tests in this area. So this small patch series now introduces some tests for CD-ROM drives: The first two patches introduce the possibility to check that booting from CD-ROM drives still works fine for x86 and s390x, and the third patch adds a test that certain machines can at least still be started with the "-cdrom" parameter (i.e. that test would have catched the mistake that I did with my SCSI cleanup patch). v2: - Use g_spawn_sync() instead of execlp() to run genisoimage - The "-cdrom" parameter test is now run on all architectures (with machine "none" for the machines that are not explicitly checked) - Some rewordings and improved comments here and there Thomas Huth (3): tests/boot-sector: Add magic bytes to s390x boot code header tests/cdrom-test: Test booting from CD-ROM ISO image file tests/cdrom-test: Test that -cdrom parameter is working tests/Makefile.include | 2 + tests/boot-sector.c | 9 +- tests/cdrom-test.c | 222 +++++++++++++++++++++++++++++++++++++++++++= ++++++ 3 files changed, 230 insertions(+), 3 deletions(-) create mode 100644 tests/cdrom-test.c --=20 1.8.3.1