From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eykeS-00024g-O4 for qemu-devel@nongnu.org; Wed, 21 Mar 2018 16:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eykeR-00028j-P6 for qemu-devel@nongnu.org; Wed, 21 Mar 2018 16:48:04 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:44141) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eykeR-00028K-J2 for qemu-devel@nongnu.org; Wed, 21 Mar 2018 16:48:03 -0400 Received: by mail-pg0-x244.google.com with SMTP id l4so2399651pgp.11 for ; Wed, 21 Mar 2018 13:48:03 -0700 (PDT) From: Michael Clark Date: Wed, 21 Mar 2018 13:46:50 -0700 Message-Id: <1521665220-3869-15-git-send-email-mjc@sifive.com> In-Reply-To: <1521665220-3869-1-git-send-email-mjc@sifive.com> References: <1521665220-3869-1-git-send-email-mjc@sifive.com> Subject: [Qemu-devel] [PULL 14/24] RISC-V: Use memory_region_is_ram in pte update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@groups.riscv.org, Michael Clark , Sagar Karandikar , Bastian Koppelmann , Palmer Dabbelt After reading cpu_physical_memory_write and friends, it seems that memory_region_is_ram is a more appropriate interface, and matches the intent of the code that is calling it. Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/helper.c b/target/riscv/helper.c index 9010620..b2e3f45 100644 --- a/target/riscv/helper.c +++ b/target/riscv/helper.c @@ -234,7 +234,7 @@ restart: hwaddr l = sizeof(target_ulong), addr1; mr = address_space_translate(cs->as, pte_addr, &addr1, &l, false); - if (memory_access_is_direct(mr, true)) { + if (memory_region_is_ram(mr)) { target_ulong *pte_pa = qemu_map_ram_ptr(mr->ram_block, addr1); #if TCG_OVERSIZED_GUEST -- 2.7.0