From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGmFf-0007jb-FS for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:46:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGmFa-0005UL-Cx for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:46:19 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:44229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGmFa-0005UA-4b for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:46:14 -0400 Date: Tue, 3 Sep 2013 04:46:11 -0400 (EDT) From: Miroslav Rezanina Message-ID: <1521731216.5957480.1378197971859.JavaMail.root@redhat.com> In-Reply-To: <1378194071.3618.8.camel@nilsson.home.kraxel.org> References: <1378194071.3618.8.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org ----- Original Message ----- > From: "Gerd Hoffmann" > To: mrezanin@redhat.com > Cc: qemu-devel@nongnu.org > Sent: Tuesday, September 3, 2013 9:41:11 AM > Subject: Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable > > > diff --git a/hw/bt/core.c b/hw/bt/core.c > > index 49012e0..ef27b15 100644 > > --- a/hw/bt/core.c > > +++ b/hw/bt/core.c > > @@ -119,3 +119,28 @@ void bt_device_done(struct bt_device_s *dev) > > > > *p = dev->next; > > } > > + > > +static struct bt_vlan_s { > > + struct bt_scatternet_s net; > > + int id; > > + struct bt_vlan_s *next; > > +} *first_bt_vlan; > > + > > +/* find or alloc a new bluetooth "VLAN" */ > > +struct bt_scatternet_s *qemu_find_bt_vlan(int id) > > +{ > > + struct bt_vlan_s **pvlan, *vlan; > > + for (vlan = first_bt_vlan; vlan != NULL; vlan = vlan->next) { > > + if (vlan->id == id) { > > + return &vlan->net; > > + } > > + } > > + vlan = g_malloc0(sizeof(struct bt_vlan_s)); > > + vlan->id = id; > > + pvlan = &first_bt_vlan; > > + while (*pvlan != NULL) { > > + pvlan = &(*pvlan)->next; > > + } > > + *pvlan = vlan; > > + return &vlan->net; > > +} > > This (and some other bits) are pure code motion from vl.c, correct? > Can you split this into a separate patch please? That'll simplify the > review o the actual code changes. Yes, this is pure code motion. I'll split the code to separate patches. > > It also doesn't make much sense to compile hw/bt/ with > CONFIG_USB_BLUETOOTH=n. It's basically dead code then. > Is this true? So -bt option is not useable without usb-bt-dongle? > cheers, > Gerd > > > -- Miroslav Rezanina Software Engineer - Virtualization Team