From: <saipavanboddu@gmail.com>
To: Alistair Francis <alistair@alistair23.me>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>,
"Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
"Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [qemu-devel][PATCH v1 2/2] xilinx_spi: use qdev_init_gpio_out for gpio init
Date: Tue, 27 Mar 2018 12:51:13 +0530 [thread overview]
Message-ID: <1522135274-15396-2-git-send-email-saipavanboddu@gmail.com> (raw)
In-Reply-To: <1522135274-15396-1-git-send-email-saipavanboddu@gmail.com>
From: Sai Pavan Boddu <saipava@xilinx.com>
useful to connect gpio with qdev_connect_gpio_out
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/ssi/xilinx_spi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c
index 83585bc..dcd1a2f 100644
--- a/hw/ssi/xilinx_spi.c
+++ b/hw/ssi/xilinx_spi.c
@@ -323,7 +323,6 @@ static int xilinx_spi_init(SysBusDevice *sbd)
{
DeviceState *dev = DEVICE(sbd);
XilinxSPI *s = XILINX_SPI(dev);
- int i;
DB_PRINT("\n");
@@ -332,9 +331,7 @@ static int xilinx_spi_init(SysBusDevice *sbd)
sysbus_init_irq(sbd, &s->irq);
s->cs_lines = g_new0(qemu_irq, s->num_cs);
ssi_auto_connect_slaves(dev, s->cs_lines, s->spi);
- for (i = 0; i < s->num_cs; ++i) {
- sysbus_init_irq(sbd, &s->cs_lines[i]);
- }
+ qdev_init_gpio_out(dev, s->cs_lines, s->num_cs);
memory_region_init_io(&s->mmio, OBJECT(s), &spi_ops, s,
"xilinx-spi", R_MAX * 4);
--
2.7.4
prev parent reply other threads:[~2018-03-27 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 7:21 [Qemu-devel] [qemu-devel][PATCH v1 1/2] ssi.c: Check if slave already attached to a parent bus saipavanboddu
2018-03-27 7:21 ` saipavanboddu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522135274-15396-2-git-send-email-saipavanboddu@gmail.com \
--to=saipavanboddu@gmail.com \
--cc=alistair@alistair23.me \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).