From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 2/6] e1000: Dupe offload data on reading old stream
Date: Tue, 10 Apr 2018 11:39:58 +0800 [thread overview]
Message-ID: <1523331602-18781-3-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1523331602-18781-1-git-send-email-jasowang@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Old QEMUs only had one set of offload data; when we only receive
one lot, dupe the received data - that should give us about the
same bug level as the old version.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/e1000.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 24e9a4a..d399ce3 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -127,6 +127,7 @@ typedef struct E1000State_st {
#define E1000_FLAG_MIT (1 << E1000_FLAG_MIT_BIT)
#define E1000_FLAG_MAC (1 << E1000_FLAG_MAC_BIT)
uint32_t compat_flags;
+ bool received_tx_tso;
} E1000State;
#define chkflag(x) (s->compat_flags & E1000_FLAG_##x)
@@ -1390,6 +1391,20 @@ static int e1000_post_load(void *opaque, int version_id)
qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + 500);
}
+ if (!s->received_tx_tso) {
+ /* We received only one set of offload data (tx.props)
+ * and haven't got tx.tso_props. The best we can do
+ * is dupe the data.
+ */
+ s->tx.tso_props = s->tx.props;
+ }
+ return 0;
+}
+
+static int e1000_tx_tso_post_load(void *opaque, int version_id)
+{
+ E1000State *s = opaque;
+ s->received_tx_tso = true;
return 0;
}
@@ -1437,6 +1452,7 @@ static const VMStateDescription vmstate_e1000_tx_tso_state = {
.name = "e1000/tx_tso_state",
.version_id = 1,
.minimum_version_id = 1,
+ .post_load = e1000_tx_tso_post_load,
.fields = (VMStateField[]) {
VMSTATE_UINT8(tx.tso_props.ipcss, E1000State),
VMSTATE_UINT8(tx.tso_props.ipcso, E1000State),
--
2.7.4
next prev parent reply other threads:[~2018-04-10 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 3:39 [Qemu-devel] [PULL 0/6] Net patches Jason Wang
2018-04-10 3:39 ` [Qemu-devel] [PULL 1/6] e1000: Convert v3 fields to subsection Jason Wang
2018-04-10 3:39 ` Jason Wang [this message]
2018-04-10 3:39 ` [Qemu-devel] [PULL 3/6] e1000: wire new subsection to property Jason Wang
2018-04-10 3:40 ` [Qemu-devel] [PULL 4/6] e1000: Migrate props via a temporary structure Jason Wang
2018-04-10 3:40 ` [Qemu-devel] [PULL 5/6] e1000: Choose which set of props to migrate Jason Wang
2018-04-10 3:40 ` [Qemu-devel] [PULL 6/6] e1000: Old machine types, turn new subsection off Jason Wang
2018-04-10 13:04 ` [Qemu-devel] [PULL 0/6] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523331602-18781-3-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).