* [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB
@ 2018-04-12 13:55 Geert Uytterhoeven
2018-04-16 12:20 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-04-12 13:55 UTC (permalink / raw)
To: Peter Crosthwaite, Alexander Graf
Cc: Peter Maydell, qemu-devel, linux-renesas-soc, Geert Uytterhoeven
It is not uncommon for a contemporary FDT to be larger than 64 KiB,
leading to failures loading the device tree from sysfs:
qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE
Hence increase the limit to 1 MiB, like on PPC.
For reference, the largest arm64 DTB created from the Linux sources is
ca. 75 KiB large (100 KiB when built with symbols/fixup support).
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3:
- Update example size figures,
v2:
- Enlarge from 128 KiB to 1 MiB, as suggested by Peter Maydell.
---
device_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/device_tree.c b/device_tree.c
index 19458b32bf81e55e..52c3358a55838d33 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -29,7 +29,7 @@
#include <libfdt.h>
-#define FDT_MAX_SIZE 0x10000
+#define FDT_MAX_SIZE 0x100000
void *create_device_tree(int *sizep)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB
2018-04-12 13:55 [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB Geert Uytterhoeven
@ 2018-04-16 12:20 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2018-04-16 12:20 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Peter Crosthwaite, Alexander Graf, QEMU Developers, Linux-Renesas,
qemu-stable
On 12 April 2018 at 14:55, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> It is not uncommon for a contemporary FDT to be larger than 64 KiB,
> leading to failures loading the device tree from sysfs:
>
> qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE
>
> Hence increase the limit to 1 MiB, like on PPC.
>
> For reference, the largest arm64 DTB created from the Linux sources is
> ca. 75 KiB large (100 KiB when built with symbols/fixup support).
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
> - Update example size figures,
>
> v2:
> - Enlarge from 128 KiB to 1 MiB, as suggested by Peter Maydell.
> ---
> device_tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks; applied to target-arm.next for 2.13. I'll add cc:qemu-stable too.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-16 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-12 13:55 [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB Geert Uytterhoeven
2018-04-16 12:20 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).