From: Thomas Huth <thuth@redhat.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: chen.zhang@intel.com, lvivier@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/qtest: check the return value
Date: Tue, 21 Nov 2023 09:19:44 +0100 [thread overview]
Message-ID: <1523ba13-1047-4ec5-88e7-d8672ec22f2d@redhat.com> (raw)
In-Reply-To: <20231121080802.4500-1-zhujun2@cmss.chinamobile.com>
On 21/11/2023 09.08, Zhu Jun wrote:
> These variables "ret" are never referenced in the code, thus
> add check logic for the "ret"
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Thanks!
Reviewed-by: Thomas Huth <thuth@redhat.com>
I'll queue it for my next pull request.
next prev parent reply other threads:[~2023-11-21 8:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 8:00 [PATCH] tests/qtest: remove unused variables zhujun2
2023-11-15 8:08 ` Thomas Huth
2023-11-16 2:14 ` Zhang, Chen
2023-11-21 6:16 ` [PATCH] tests/qtest: check the return value zhujun2
2023-11-21 6:41 ` Thomas Huth
2023-11-21 8:08 ` Zhu Jun
2023-11-21 8:19 ` Thomas Huth [this message]
2023-11-21 7:09 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523ba13-1047-4ec5-88e7-d8672ec22f2d@redhat.com \
--to=thuth@redhat.com \
--cc=chen.zhang@intel.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).