qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
To: alistair@alistair23.me, crosthwaite.peter@gmail.com,
	peter.maydell@linaro.org, edgar.iglesias@gmail.com,
	frasse.iglesias@gmail.com
Cc: qemu-devel@nongnu.org, saipava@xilinx.com
Subject: [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo
Date: Thu, 19 Apr 2018 11:57:23 +0530	[thread overview]
Message-ID: <1524119244-1240-1-git-send-email-saipava@xilinx.com> (raw)

SNOOP_NONE state handle is moved above in the if ladder, as it's same
as SNOOP_STRIPPING during data cycles.

Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
---
Changes for V2:
	Fixed commit message
	Reordered to code, to avoid code duplication.
Changes for V3:
	Dropped the cover letter, as its a minor fix now
	Fixed commit message by explaining only what's fixed
	removed the dummy_byte decrement changes

 hw/ssi/xilinx_spips.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 426f971..03f5fae 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -616,7 +616,8 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s)
         if (fifo8_is_empty(&s->tx_fifo)) {
             xilinx_spips_update_ixr(s);
             return;
-        } else if (s->snoop_state == SNOOP_STRIPING) {
+        } else if (s->snoop_state == SNOOP_STRIPING ||
+                   s->snoop_state == SNOOP_NONE) {
             for (i = 0; i < num_effective_busses(s); ++i) {
                 tx_rx[i] = fifo8_pop(&s->tx_fifo);
             }
-- 
2.7.4

             reply	other threads:[~2018-04-19  6:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  6:27 Sai Pavan Boddu [this message]
2018-04-20 17:26 ` [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo francisco iglesias
2018-04-23 10:42   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524119244-1240-1-git-send-email-saipava@xilinx.com \
    --to=sai.pavan.boddu@xilinx.com \
    --cc=alistair@alistair23.me \
    --cc=crosthwaite.peter@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=frasse.iglesias@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).