* [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo
@ 2018-04-19 6:27 Sai Pavan Boddu
2018-04-20 17:26 ` francisco iglesias
0 siblings, 1 reply; 3+ messages in thread
From: Sai Pavan Boddu @ 2018-04-19 6:27 UTC (permalink / raw)
To: alistair, crosthwaite.peter, peter.maydell, edgar.iglesias,
frasse.iglesias
Cc: qemu-devel, saipava
SNOOP_NONE state handle is moved above in the if ladder, as it's same
as SNOOP_STRIPPING during data cycles.
Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
---
Changes for V2:
Fixed commit message
Reordered to code, to avoid code duplication.
Changes for V3:
Dropped the cover letter, as its a minor fix now
Fixed commit message by explaining only what's fixed
removed the dummy_byte decrement changes
hw/ssi/xilinx_spips.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 426f971..03f5fae 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -616,7 +616,8 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s)
if (fifo8_is_empty(&s->tx_fifo)) {
xilinx_spips_update_ixr(s);
return;
- } else if (s->snoop_state == SNOOP_STRIPING) {
+ } else if (s->snoop_state == SNOOP_STRIPING ||
+ s->snoop_state == SNOOP_NONE) {
for (i = 0; i < num_effective_busses(s); ++i) {
tx_rx[i] = fifo8_pop(&s->tx_fifo);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo
2018-04-19 6:27 [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo Sai Pavan Boddu
@ 2018-04-20 17:26 ` francisco iglesias
2018-04-23 10:42 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: francisco iglesias @ 2018-04-20 17:26 UTC (permalink / raw)
To: Sai Pavan Boddu
Cc: alistair, Peter Crosthwaite, Peter Maydell, Edde, Sai Pavan Boddu,
qemu-devel@nongnu.org Developers
On 19 April 2018 at 08:27, Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
wrote:
> SNOOP_NONE state handle is moved above in the if ladder, as it's same
> as SNOOP_STRIPPING during data cycles.
>
> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> Changes for V2:
> Fixed commit message
> Reordered to code, to avoid code duplication.
> Changes for V3:
> Dropped the cover letter, as its a minor fix now
> Fixed commit message by explaining only what's fixed
> removed the dummy_byte decrement changes
>
> hw/ssi/xilinx_spips.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index 426f971..03f5fae 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -616,7 +616,8 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s)
> if (fifo8_is_empty(&s->tx_fifo)) {
> xilinx_spips_update_ixr(s);
> return;
> - } else if (s->snoop_state == SNOOP_STRIPING) {
> + } else if (s->snoop_state == SNOOP_STRIPING ||
> + s->snoop_state == SNOOP_NONE) {
> for (i = 0; i < num_effective_busses(s); ++i) {
> tx_rx[i] = fifo8_pop(&s->tx_fifo);
> }
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo
2018-04-20 17:26 ` francisco iglesias
@ 2018-04-23 10:42 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-04-23 10:42 UTC (permalink / raw)
To: francisco iglesias
Cc: Sai Pavan Boddu, Alistair Francis, Peter Crosthwaite, Edde,
Sai Pavan Boddu, qemu-devel@nongnu.org Developers
On 20 April 2018 at 18:26, francisco iglesias <frasse.iglesias@gmail.com> wrote:
>
>
> On 19 April 2018 at 08:27, Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> wrote:
>>
>> SNOOP_NONE state handle is moved above in the if ladder, as it's same
>> as SNOOP_STRIPPING during data cycles.
>>
>> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
>
>
> Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
>
>>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-23 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-19 6:27 [Qemu-devel] [PATCH v3] xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo Sai Pavan Boddu
2018-04-20 17:26 ` francisco iglesias
2018-04-23 10:42 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).