From: Wei Wang <wei.w.wang@intel.com>
To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com
Cc: pbonzini@redhat.com, wei.w.wang@intel.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com
Subject: [Qemu-devel] [PATCH v7 3/5] migration: API to clear bits of guest free pages from the dirty bitmap
Date: Tue, 24 Apr 2018 14:13:46 +0800 [thread overview]
Message-ID: <1524550428-27173-4-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1524550428-27173-1-git-send-email-wei.w.wang@intel.com>
This patch adds an API to clear bits corresponding to guest free pages
from the dirty bitmap. Spilt the free page block if it crosses the QEMU
RAMBlock boundary.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
---
include/migration/misc.h | 2 ++
migration/ram.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 46 insertions(+)
diff --git a/include/migration/misc.h b/include/migration/misc.h
index 4ebf24c..113320e 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -14,11 +14,13 @@
#ifndef MIGRATION_MISC_H
#define MIGRATION_MISC_H
+#include "exec/cpu-common.h"
#include "qemu/notify.h"
/* migration/ram.c */
void ram_mig_init(void);
+void qemu_guest_free_page_hint(void *addr, size_t len);
/* migration/block.c */
diff --git a/migration/ram.c b/migration/ram.c
index 9a72b1a..0147548 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2198,6 +2198,50 @@ static int ram_init_all(RAMState **rsp)
}
/*
+ * This function clears bits of the free pages reported by the caller from the
+ * migration dirty bitmap. @addr is the host address corresponding to the
+ * start of the continuous guest free pages, and @len is the total bytes of
+ * those pages.
+ */
+void qemu_guest_free_page_hint(void *addr, size_t len)
+{
+ RAMBlock *block;
+ ram_addr_t offset;
+ size_t used_len, start, npages;
+
+ for (; len > 0; len -= used_len) {
+ block = qemu_ram_block_from_host(addr, false, &offset);
+ if (unlikely(!block)) {
+ return;
+ }
+
+ /*
+ * This handles the case that the RAMBlock is resized after the free
+ * page hint is reported.
+ */
+ if (unlikely(offset > block->used_length)) {
+ return;
+ }
+
+ if (len <= block->used_length - offset) {
+ used_len = len;
+ } else {
+ used_len = block->used_length - offset;
+ addr += used_len;
+ }
+
+ start = offset >> TARGET_PAGE_BITS;
+ npages = used_len >> TARGET_PAGE_BITS;
+
+ qemu_mutex_lock(&ram_state->bitmap_mutex);
+ ram_state->migration_dirty_pages -=
+ bitmap_count_one_with_offset(block->bmap, start, npages);
+ bitmap_clear(block->bmap, start, npages);
+ qemu_mutex_unlock(&ram_state->bitmap_mutex);
+ }
+}
+
+/*
* Each of ram_save_setup, ram_save_iterate and ram_save_complete has
* long-running RCU critical section. When rcu-reclaims in the code
* start to become numerous it will be necessary to reduce the
--
1.8.3.1
next prev parent reply other threads:[~2018-04-24 6:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 6:13 [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support Wei Wang
2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 1/5] bitmap: bitmap_count_one_with_offset Wei Wang
2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 2/5] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang
2018-06-01 3:37 ` Peter Xu
2018-04-24 6:13 ` Wei Wang [this message]
2018-06-01 4:00 ` [Qemu-devel] [PATCH v7 3/5] migration: API to clear bits of guest free pages from the dirty bitmap Peter Xu
2018-06-01 7:36 ` Wei Wang
2018-06-01 10:06 ` Peter Xu
2018-06-01 12:32 ` Wei Wang
2018-06-04 2:49 ` Peter Xu
2018-06-04 7:43 ` Wei Wang
2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-05-29 15:24 ` Michael S. Tsirkin
2018-05-30 9:12 ` Wei Wang
2018-05-30 12:47 ` Michael S. Tsirkin
2018-05-31 2:27 ` Wei Wang
2018-05-31 17:42 ` Michael S. Tsirkin
2018-06-01 3:18 ` Wei Wang
2018-06-04 8:04 ` Wei Wang
2018-06-05 6:58 ` Peter Xu
2018-06-05 13:22 ` Wei Wang
2018-06-06 5:42 ` Peter Xu
2018-06-06 10:04 ` Wei Wang
2018-06-06 11:02 ` Peter Xu
2018-06-07 5:24 ` Wei Wang
2018-06-07 6:32 ` Peter Xu
2018-06-07 11:59 ` Wei Wang
2018-06-08 2:17 ` Peter Xu
2018-06-08 7:14 ` Wei Wang
2018-06-08 7:31 ` Wei Wang
2018-06-06 6:43 ` Peter Xu
2018-06-06 10:11 ` Wei Wang
2018-06-07 3:17 ` Peter Xu
2018-06-07 5:29 ` Wei Wang
2018-06-07 6:58 ` Peter Xu
2018-06-07 12:01 ` Wei Wang
2018-06-08 1:37 ` Peter Xu
2018-06-08 1:58 ` Peter Xu
2018-06-08 1:58 ` Michael S. Tsirkin
2018-06-08 2:34 ` Peter Xu
2018-06-08 2:49 ` Michael S. Tsirkin
2018-06-08 3:34 ` Peter Xu
2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 5/5] migration: use the free page hint feature from balloon Wei Wang
2018-04-24 6:42 ` [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support Wei Wang
2018-05-14 1:22 ` Wei Wang
2018-05-29 15:00 ` Hailiang Zhang
2018-05-29 15:24 ` Michael S. Tsirkin
2018-06-01 4:58 ` Peter Xu
2018-06-01 5:07 ` Peter Xu
2018-06-01 7:29 ` Wei Wang
2018-06-01 10:02 ` Peter Xu
2018-06-01 12:31 ` Wei Wang
2018-06-01 7:21 ` Wei Wang
2018-06-01 10:40 ` Peter Xu
2018-06-01 15:33 ` Dr. David Alan Gilbert
2018-06-05 6:42 ` Peter Xu
2018-06-05 14:40 ` Michael S. Tsirkin
2018-06-05 14:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524550428-27173-4-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=dgilbert@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu0@gmail.com \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).