From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
Anthony PERARD <anthony.perard@citrix.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Qemu-devel] [PULL 01/16] checkpatch: Add xendevicemodel_handle to the list of types
Date: Thu, 26 Apr 2018 16:56:12 +0100 [thread overview]
Message-ID: <1524758187-9351-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1524758187-9351-1-git-send-email-ian.jackson@eu.citrix.com>
This avoids checkpatch misparsing (as statements) long function
definitions or declarations, which sometimes start with constructs
like this:
static inline int xendevicemodel_relocate_memory(
xendevicemodel_handle *dmod, domid_t domid, ...
The type xendevicemodel_handle does not conform to Qemu CODING_STYLE,
which would suggest CamelCase. However, it is a type defined by the
Xen Project in xen.git. It would be possible to introduce a typedef
to allow the qemu code to refer to it by a differently-spelled name,
but that would obfuscate more than it would clarify.
CC: Eric Blake <eblake@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d52207a..5b8735d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -266,6 +266,7 @@ our @typeList = (
qr{target_(?:u)?long},
qr{hwaddr},
qr{xml${Ident}},
+ qr{xendevicemodel_handle},
);
# This can be modified by sub possible. Since it can be empty, be careful
--
2.1.4
next prev parent reply other threads:[~2018-04-26 15:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 15:56 [Qemu-devel] [PULL v9 00/16] xen: xen-domid-restrict improvements Ian Jackson
2018-04-26 15:56 ` Ian Jackson [this message]
2018-04-26 15:56 ` [Qemu-devel] [PULL 02/16] AccelClass: Introduce accel_setup_post Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 03/16] xen: link against xentoolcore Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 04/16] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 05/16] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 06/16] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 07/16] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 10/16] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 11/16] xen: Use newly added dmops for mapping VGA memory Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 13/16] xen: Expect xenstore write to fail when restricted Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 15/16] os-posix: cleanup: Replace perror with error_report Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 16/16] configure: do_compiler: Dump some extra info under bash Ian Jackson
2018-04-26 17:27 ` [Qemu-devel] [PULL v9 00/16] xen: xen-domid-restrict improvements Peter Maydell
2018-04-26 17:36 ` Ian Jackson
2018-04-26 17:41 ` Peter Maydell
2018-04-26 18:13 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524758187-9351-2-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jgross@suse.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).