qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Qemu-devel] [PULL 06/16] xen: destroy_hvm_domain: Move reason into a variable
Date: Thu, 26 Apr 2018 16:56:17 +0100	[thread overview]
Message-ID: <1524758187-9351-7-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1524758187-9351-1-git-send-email-ian.jackson@eu.citrix.com>

We are going to want to reuse this.

No functional change.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
---
 hw/i386/xen/xen-hvm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index 9c3b6b3..3590d99 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -1387,12 +1387,13 @@ void destroy_hvm_domain(bool reboot)
     xc_interface *xc_handle;
     int sts;
 
+    unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff;
+
     xc_handle = xc_interface_open(0, 0, 0);
     if (xc_handle == NULL) {
         fprintf(stderr, "Cannot acquire xenctrl handle\n");
     } else {
-        sts = xc_domain_shutdown(xc_handle, xen_domid,
-                                 reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff);
+        sts = xc_domain_shutdown(xc_handle, xen_domid, reason);
         if (sts != 0) {
             fprintf(stderr, "xc_domain_shutdown failed to issue %s, "
                     "sts %d, %s\n", reboot ? "reboot" : "poweroff",
-- 
2.1.4

  parent reply	other threads:[~2018-04-26 15:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 15:56 [Qemu-devel] [PULL v9 00/16] xen: xen-domid-restrict improvements Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 01/16] checkpatch: Add xendevicemodel_handle to the list of types Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 02/16] AccelClass: Introduce accel_setup_post Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 03/16] xen: link against xentoolcore Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 04/16] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 05/16] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2018-04-26 15:56 ` Ian Jackson [this message]
2018-04-26 15:56 ` [Qemu-devel] [PULL 07/16] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 10/16] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 11/16] xen: Use newly added dmops for mapping VGA memory Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 13/16] xen: Expect xenstore write to fail when restricted Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 15/16] os-posix: cleanup: Replace perror with error_report Ian Jackson
2018-04-26 15:56 ` [Qemu-devel] [PULL 16/16] configure: do_compiler: Dump some extra info under bash Ian Jackson
2018-04-26 17:27 ` [Qemu-devel] [PULL v9 00/16] xen: xen-domid-restrict improvements Peter Maydell
2018-04-26 17:36   ` Ian Jackson
2018-04-26 17:41     ` Peter Maydell
2018-04-26 18:13       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524758187-9351-7-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=jgross@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).