From: Babu Moger <babu.moger@amd.com>
To: mst@redhat.com, marcel@redhat.com, pbonzini@redhat.com,
rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, kash@tripleback.net,
geoff@hostfission.com, babu.moger@amd.com
Subject: [Qemu-devel] [PATCH v7 5/9] i386: Use the statically loaded cache definitions
Date: Thu, 26 Apr 2018 11:26:45 -0500 [thread overview]
Message-ID: <1524760009-24710-6-git-send-email-babu.moger@amd.com> (raw)
In-Reply-To: <1524760009-24710-1-git-send-email-babu.moger@amd.com>
Use the statically loaded cache definitions if available
and legacy-cache parameter is not set.
Signed-off-by: Babu Moger <babu.moger@amd.com>
Tested-by: Geoffrey McRae <geoff@hostfission.com>
---
target/i386/cpu.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index a27b658..56d2f0b 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3941,8 +3941,13 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
(L1_ITLB_2M_ASSOC << 8) | (L1_ITLB_2M_ENTRIES);
*ebx = (L1_DTLB_4K_ASSOC << 24) | (L1_DTLB_4K_ENTRIES << 16) | \
(L1_ITLB_4K_ASSOC << 8) | (L1_ITLB_4K_ENTRIES);
- *ecx = encode_cache_cpuid80000005(&l1d_cache_amd);
- *edx = encode_cache_cpuid80000005(&l1i_cache_amd);
+ if (env->cache_info.valid && !cpu->legacy_cache) {
+ *ecx = encode_cache_cpuid80000005(&env->cache_info.l1d_cache);
+ *edx = encode_cache_cpuid80000005(&env->cache_info.l1i_cache);
+ } else {
+ *ecx = encode_cache_cpuid80000005(&l1d_cache_amd);
+ *edx = encode_cache_cpuid80000005(&l1i_cache_amd);
+ }
break;
case 0x80000006:
/* cache info (L2 cache) */
@@ -3958,9 +3963,16 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
(L2_DTLB_4K_ENTRIES << 16) | \
(AMD_ENC_ASSOC(L2_ITLB_4K_ASSOC) << 12) | \
(L2_ITLB_4K_ENTRIES);
- encode_cache_cpuid80000006(&l2_cache_amd,
- cpu->enable_l3_cache ? &l3_cache : NULL,
- ecx, edx);
+ if (env->cache_info.valid && !cpu->legacy_cache) {
+ encode_cache_cpuid80000006(&env->cache_info.l2_cache,
+ cpu->enable_l3_cache ?
+ &env->cache_info.l3_cache : NULL,
+ ecx, edx);
+ } else {
+ encode_cache_cpuid80000006(&l2_cache_amd,
+ cpu->enable_l3_cache ? &l3_cache : NULL,
+ ecx, edx);
+ }
break;
case 0x80000007:
*eax = 0;
--
2.7.4
next prev parent reply other threads:[~2018-04-26 16:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 16:26 [Qemu-devel] [PATCH v7 0/9] i386: Enable TOPOEXT to support hyperthreading on AMD CPU Babu Moger
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 1/9] i386: Helpers to encode cache information consistently Babu Moger
2018-05-07 19:05 ` Eduardo Habkost
2018-05-07 21:14 ` Moger, Babu
2018-05-07 21:27 ` Eduardo Habkost
2018-05-07 22:47 ` Moger, Babu
2018-05-08 18:40 ` Moger, Babu
2018-05-08 19:07 ` Eduardo Habkost
2018-05-08 19:34 ` Moger, Babu
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 2/9] i386: Add cache information in X86CPUDefinition Babu Moger
2018-05-07 19:09 ` Eduardo Habkost
2018-05-07 22:56 ` Moger, Babu
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 3/9] i386: Initialize cache information for EPYC family processors Babu Moger
2018-05-07 20:22 ` Eduardo Habkost
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 4/9] i386: Add new property to control cache info Babu Moger
2018-05-07 19:14 ` Eduardo Habkost
2018-05-07 23:29 ` Moger, Babu
2018-05-08 14:25 ` Eduardo Habkost
2018-05-08 17:26 ` Moger, Babu
2018-05-08 18:33 ` Eduardo Habkost
2018-05-08 18:44 ` Moger, Babu
2018-04-26 16:26 ` Babu Moger [this message]
2018-05-07 19:15 ` [Qemu-devel] [PATCH v7 5/9] i386: Use the statically loaded cache definitions Eduardo Habkost
2018-05-07 23:32 ` Moger, Babu
2018-05-07 19:37 ` Eduardo Habkost
2018-05-07 23:39 ` Moger, Babu
2018-05-08 14:12 ` Eduardo Habkost
2018-05-08 17:08 ` Moger, Babu
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 6/9] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D Babu Moger
2018-05-07 21:06 ` Eduardo Habkost
2018-05-08 16:41 ` Moger, Babu
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 7/9] i386: Add support for CPUID_8000_001E for AMD Babu Moger
2018-05-07 19:39 ` Eduardo Habkost
2018-05-07 23:44 ` Moger, Babu
2018-05-08 14:16 ` Eduardo Habkost
2018-05-08 15:02 ` Moger, Babu
2018-05-11 14:12 ` Eduardo Habkost
2018-05-11 14:44 ` Moger, Babu
2018-05-11 14:59 ` Eduardo Habkost
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 8/9] i386: Enable TOPOEXT feature on AMD EPYC CPU Babu Moger
2018-05-07 21:07 ` Eduardo Habkost
2018-04-26 16:26 ` [Qemu-devel] [PATCH v7 9/9] i386: Remove generic SMT thread check Babu Moger
2018-05-07 21:14 ` Eduardo Habkost
2018-04-26 20:49 ` [Qemu-devel] [PATCH v7 0/9] i386: Enable TOPOEXT to support hyperthreading on AMD CPU geoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524760009-24710-6-git-send-email-babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=ehabkost@redhat.com \
--cc=geoff@hostfission.com \
--cc=kash@tripleback.net \
--cc=kvm@vger.kernel.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).