qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue
@ 2018-04-28  5:54 Jay Zhou
  2018-05-08  9:57 ` Stefan Hajnoczi
  0 siblings, 1 reply; 2+ messages in thread
From: Jay Zhou @ 2018-04-28  5:54 UTC (permalink / raw)
  To: qemu-devel
  Cc: mst, arei.gonglei, wangxinxin.wang, weidong.huang, jianjay.zhou

This patch removes the dead code, which fixes Coverity (CID 1390600) issue.

Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
---
 backends/cryptodev-vhost-user.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
index 862d4f2..67e65c6 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -155,7 +155,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
 {
     CryptoDevBackendVhostUser *s = opaque;
     CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
-    Error *err = NULL;
     int queues = b->conf.peers.queues;
 
     assert(queues < MAX_CRYPTO_QUEUE_NUM);
@@ -172,10 +171,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
         cryptodev_vhost_user_stop(queues, s);
         break;
     }
-
-    if (err) {
-        error_report_err(err);
-    }
 }
 
 static void cryptodev_vhost_user_init(
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue
  2018-04-28  5:54 [Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue Jay Zhou
@ 2018-05-08  9:57 ` Stefan Hajnoczi
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2018-05-08  9:57 UTC (permalink / raw)
  To: Jay Zhou; +Cc: qemu-devel, wangxinxin.wang, arei.gonglei, weidong.huang, mst

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

On Sat, Apr 28, 2018 at 01:54:24PM +0800, Jay Zhou wrote:
> This patch removes the dead code, which fixes Coverity (CID 1390600) issue.
> 
> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---
>  backends/cryptodev-vhost-user.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-08  9:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-28  5:54 [Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue Jay Zhou
2018-05-08  9:57 ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).