qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH 4/4] qemu-options: Remove deprecated -no-kvm
Date: Wed,  2 May 2018 19:24:28 +0200	[thread overview]
Message-ID: <1525281868-24747-5-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1525281868-24747-1-git-send-email-thuth@redhat.com>

We've never documented this option in our qemu-doc, so unless the users
used qemu-kvm before, they never should never have been aware of this
option. It's been marked as deprecated in the source code since a long
time already, and officially marked as deprecated in the documentation
since QEMU v2.10, so it should be fine to remove this now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-doc.texi   | 5 -----
 qemu-options.hx | 3 ---
 vl.c            | 4 ----
 3 files changed, 12 deletions(-)

diff --git a/qemu-doc.texi b/qemu-doc.texi
index f605557..1c61a6a 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2786,11 +2786,6 @@ which is the default.
 
 @section System emulator command line arguments
 
-@subsection -no-kvm (since 1.3.0)
-
-The ``-no-kvm'' argument is now a synonym for setting
-``-machine accel=tcg''.
-
 @subsection -vnc tls (since 2.5.0)
 
 The ``-vnc tls'' argument is now a synonym for setting
diff --git a/qemu-options.hx b/qemu-options.hx
index 870a363..d77a968 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3914,9 +3914,6 @@ STEXI
 Enable FIPS 140-2 compliance mode.
 ETEXI
 
-HXCOMM Deprecated by -machine accel=tcg property
-DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
-
 DEF("msg", HAS_ARG, QEMU_OPTION_msg,
     "-msg timestamp[=on|off]\n"
     "                change the format of messages\n"
diff --git a/vl.c b/vl.c
index 0d77a48..593b197 100644
--- a/vl.c
+++ b/vl.c
@@ -3732,10 +3732,6 @@ int main(int argc, char **argv, char **envp)
                     exit(1);
                 }
                 break;
-             case QEMU_OPTION_no_kvm:
-                olist = qemu_find_opts("machine");
-                qemu_opts_parse_noisily(olist, "accel=tcg", false);
-                break;
             case QEMU_OPTION_accel:
                 accel_opts = qemu_opts_parse_noisily(qemu_find_opts("accel"),
                                                      optarg, true);
-- 
1.8.3.1

  parent reply	other threads:[~2018-05-02 17:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 17:24 [Qemu-devel] [PATCH 0/4] Removal of deprecated -no-kvm* options Thomas Huth
2018-05-02 17:24 ` [Qemu-devel] [PATCH 1/4] qemu-options: Remove remainders of the -tdf option Thomas Huth
2018-05-03  6:50   ` Markus Armbruster
2018-05-02 17:24 ` [Qemu-devel] [PATCH 2/4] qemu-options: Remove deprecated -no-kvm-pit-reinjection Thomas Huth
2018-05-03  7:07   ` Markus Armbruster
2018-05-02 17:24 ` [Qemu-devel] [PATCH 3/4] qemu-options: Remove deprecated -no-kvm-irqchip Thomas Huth
2018-05-03  7:08   ` Markus Armbruster
2018-05-02 17:24 ` Thomas Huth [this message]
2018-05-03  7:06   ` [Qemu-devel] [PATCH 4/4] qemu-options: Remove deprecated -no-kvm Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525281868-24747-5-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).