From: Jonathan Helman <jonathan.helman@oracle.com>
To: mst@redhat.com
Cc: jasowang@redhat.com, virtio-dev@lists.oasis-open.org,
qemu-devel@nongnu.org,
Jonathan Helman <jonathan.helman@oracle.com>,
Rob Gardner <rob.gardner@oracle.com>,
Thomas Tai <thomas.tai@oracle.com>
Subject: [Qemu-devel] [PATCH] virtio-balloon: fix internal stat name array to match Linux kernel
Date: Fri, 4 May 2018 09:30:45 -0700 [thread overview]
Message-ID: <1525451445-5131-1-git-send-email-jonathan.helman@oracle.com> (raw)
The Linux kernel commit b40000325044 ("virtio_balloon: add array
of stat names") defines an array of stat name strings for consumers
of the virtio interface to use via the virtio_balloon.h header
file, rather than requiring each consumer to define its own. But at
present, the stat names defined in this array by the Linux kernel
do not match up with those defined internally by QEMU. This patch
fixes this inconsistency by changing the QEMU stat names to match
those defined by the Linux kernel.
Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
Cc: Rob Gardner <rob.gardner@oracle.com>
Cc: Thomas Tai <thomas.tai@oracle.com>
---
docs/virtio-balloon-stats.txt | 4 ++--
hw/virtio/virtio-balloon.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt
index 9985e1d..7c69fdb 100644
--- a/docs/virtio-balloon-stats.txt
+++ b/docs/virtio-balloon-stats.txt
@@ -34,8 +34,8 @@ which will return a dictionary containing:
- stat-total-memory
- stat-available-memory
- stat-disk-caches
- - stat-htlb-pgalloc
- - stat-htlb-pgfail
+ - stat-hugetlb-allocations
+ - stat-hugetlb-failures
o A key named last-update, which contains the last stats update
timestamp in seconds. Since this timestamp is generated by the host,
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 1f7a87f..8421d9f 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -52,8 +52,8 @@ static const char *balloon_stat_names[] = {
[VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory",
[VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory",
[VIRTIO_BALLOON_S_CACHES] = "stat-disk-caches",
- [VIRTIO_BALLOON_S_HTLB_PGALLOC] = "stat-htlb-pgalloc",
- [VIRTIO_BALLOON_S_HTLB_PGFAIL] = "stat-htlb-pgfail",
+ [VIRTIO_BALLOON_S_HTLB_PGALLOC] = "stat-hugetlb-allocations",
+ [VIRTIO_BALLOON_S_HTLB_PGFAIL] = "stat-hugetlb-failures",
[VIRTIO_BALLOON_S_NR] = NULL
};
--
1.8.3.1
Based-on: <1524799751-151698-5-git-send-email-mst@redhat.com>
([PULL 4/4] virtio-balloon: add hugetlb page allocation counts)
next reply other threads:[~2018-05-04 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 16:30 Jonathan Helman [this message]
2018-05-04 20:07 ` [Qemu-devel] [PATCH] virtio-balloon: fix internal stat name array to match Linux kernel Michael S. Tsirkin
2018-05-07 18:42 ` Thomas Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525451445-5131-1-git-send-email-jonathan.helman@oracle.com \
--to=jonathan.helman@oracle.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rob.gardner@oracle.com \
--cc=thomas.tai@oracle.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).