From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: berrange@redhat.com, Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/5] qemu-options: Remove deprecated -no-kvm-irqchip
Date: Fri, 4 May 2018 19:01:09 +0200 [thread overview]
Message-ID: <1525453270-23074-5-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1525453270-23074-1-git-send-email-thuth@redhat.com>
We've never documented this option in our qemu-doc, so apart from the users
that already used the old qemu-kvm fork before, most users should not be
aware of this option at all. It's been marked as deprecated in the source
code for a long time already, and officially marked as deprecated in the
documentation since QEMU v2.10, so it should be fine to remove this now.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
qemu-doc.texi | 5 -----
qemu-options.hx | 3 ---
vl.c | 5 -----
3 files changed, 13 deletions(-)
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 2047ba5..9db156b 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2786,11 +2786,6 @@ which is the default.
@section System emulator command line arguments
-@subsection -no-kvm-irqchip (since 1.3.0)
-
-The ``-no-kvm-irqchip'' argument is now a synonym for
-setting ``-machine kernel_irqchip=off''.
-
@subsection -no-kvm (since 1.3.0)
The ``-no-kvm'' argument is now a synonym for setting
diff --git a/qemu-options.hx b/qemu-options.hx
index 9c0d60d..870a363 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3917,9 +3917,6 @@ ETEXI
HXCOMM Deprecated by -machine accel=tcg property
DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
-HXCOMM Deprecated by -machine kernel_irqchip=on|off property
-DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
-
DEF("msg", HAS_ARG, QEMU_OPTION_msg,
"-msg timestamp[=on|off]\n"
" change the format of messages\n"
diff --git a/vl.c b/vl.c
index bbe94ba..d8c3b09 100644
--- a/vl.c
+++ b/vl.c
@@ -3149,11 +3149,6 @@ int main(int argc, char **argv, char **envp)
exit(1);
}
switch(popt->index) {
- case QEMU_OPTION_no_kvm_irqchip: {
- olist = qemu_find_opts("machine");
- qemu_opts_parse_noisily(olist, "kernel_irqchip=off", false);
- break;
- }
case QEMU_OPTION_cpu:
/* hw initialization will check this */
cpu_model = optarg;
--
1.8.3.1
next prev parent reply other threads:[~2018-05-04 17:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 17:01 [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options Thomas Huth
2018-05-04 17:01 ` [Qemu-devel] [PATCH v2 1/5] qemu-options: Remove remainders of the -tdf option Thomas Huth
2018-05-04 17:01 ` [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them Thomas Huth
2018-05-16 16:49 ` Anthony PERARD
2018-05-16 16:51 ` Thomas Huth
2018-05-04 17:01 ` [Qemu-devel] [PATCH v2 3/5] qemu-options: Remove deprecated -no-kvm-pit-reinjection Thomas Huth
2018-05-04 17:01 ` Thomas Huth [this message]
2018-05-04 17:01 ` [Qemu-devel] [PATCH v2 5/5] qemu-options: Remove deprecated -no-kvm Thomas Huth
2018-05-04 21:57 ` [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options Paolo Bonzini
2018-05-07 5:09 ` Thomas Huth
2018-05-07 5:37 ` Markus Armbruster
2018-05-07 5:45 ` Thomas Huth
2018-05-07 7:56 ` Markus Armbruster
2018-05-07 11:02 ` Paolo Bonzini
2018-05-07 11:56 ` Markus Armbruster
2018-05-07 12:44 ` Paolo Bonzini
2018-05-07 16:50 ` Markus Armbruster
2018-05-07 17:01 ` Paolo Bonzini
2018-05-16 16:59 ` Thomas Huth
2018-05-07 11:00 ` Paolo Bonzini
2018-05-07 11:47 ` Markus Armbruster
2018-05-04 21:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525453270-23074-5-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).