qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sridhar Samudrala <sridhar.samudrala@intel.com>
To: mst@redhat.com, netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
	alexander.h.duyck@intel.com, kubakici@wp.pl,
	sridhar.samudrala@intel.com, jasowang@redhat.com,
	loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net
Date: Mon,  7 May 2018 16:09:54 -0700	[thread overview]
Message-ID: <1525734594-11134-1-git-send-email-sridhar.samudrala@intel.com> (raw)

This feature bit can be used by hypervisor to indicate virtio_net device to
act as a standby for another device with the same MAC address.

I tested this with a small change to the patch to mark the STANDBY feature 'true'
by default as i am using libvirt to start the VMs.
Is there a way to pass the newly added feature bit 'standby' to qemu via libvirt
XML file?

Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
---
 hw/net/virtio-net.c                         | 2 ++
 include/standard-headers/linux/virtio_net.h | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 90502fca7c..38b3140670 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -2198,6 +2198,8 @@ static Property virtio_net_properties[] = {
                      true),
     DEFINE_PROP_INT32("speed", VirtIONet, net_conf.speed, SPEED_UNKNOWN),
     DEFINE_PROP_STRING("duplex", VirtIONet, net_conf.duplex_str),
+    DEFINE_PROP_BIT64("standby", VirtIONet, host_features, VIRTIO_NET_F_STANDBY,
+                      false),
     DEFINE_PROP_END_OF_LIST(),
 };
 
diff --git a/include/standard-headers/linux/virtio_net.h b/include/standard-headers/linux/virtio_net.h
index e9f255ea3f..01ec09684c 100644
--- a/include/standard-headers/linux/virtio_net.h
+++ b/include/standard-headers/linux/virtio_net.h
@@ -57,6 +57,9 @@
 					 * Steering */
 #define VIRTIO_NET_F_CTRL_MAC_ADDR 23	/* Set MAC address */
 
+#define VIRTIO_NET_F_STANDBY      62    /* Act as standby for another device
+                                         * with the same MAC.
+                                         */
 #define VIRTIO_NET_F_SPEED_DUPLEX 63	/* Device set linkspeed and duplex */
 
 #ifndef VIRTIO_NET_NO_LEGACY
-- 
2.14.3

             reply	other threads:[~2018-05-07 23:10 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 23:09 Sridhar Samudrala [this message]
2018-06-05  1:41 ` [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net Samudrala, Sridhar
2018-06-05  2:06   ` Jason Wang
2018-06-06 18:17     ` Samudrala, Sridhar
2018-06-06 18:52       ` [Qemu-devel] [libvirt] " Ján Tomko
2018-06-06 19:39         ` Samudrala, Sridhar
2018-06-06 18:53       ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 12:33   ` Michael S. Tsirkin
2018-06-05 20:20     ` Samudrala, Sridhar
2018-06-05 20:37       ` Michael S. Tsirkin
2018-06-05 21:16     ` [Qemu-devel] [virtio-dev] " Siwei Liu
2018-06-05 21:32       ` Michael S. Tsirkin
2018-06-05 22:09         ` Siwei Liu
2018-06-12 11:47           ` Michael S. Tsirkin
2018-06-14  0:56             ` Siwei Liu
2018-06-06  2:29     ` [Qemu-devel] " Jason Wang
2018-06-12 11:54       ` Michael S. Tsirkin
2018-06-13  0:20         ` Samudrala, Sridhar
2018-06-13  2:41           ` Jason Wang
2018-06-13  2:38         ` Jason Wang
2018-06-13  4:24           ` Samudrala, Sridhar
2018-06-13  5:40             ` Jason Wang
2018-06-21 18:14               ` Michael S. Tsirkin
2018-06-22  1:07                 ` [Qemu-devel] [virtio-dev] " Siwei Liu
2018-06-22  2:30                   ` Michael S. Tsirkin
2018-06-22 19:43                     ` Siwei Liu
2018-06-22 21:47                       ` Michael S. Tsirkin
2018-06-22 22:25                         ` Siwei Liu
2018-06-22 22:28                           ` Michael S. Tsirkin
2018-06-11 17:26 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-12  1:54   ` Jason Wang
2018-06-12  2:17     ` Michael S. Tsirkin
2018-06-12  5:02       ` Samudrala, Sridhar
2018-06-12 11:34         ` Michael S. Tsirkin
2018-06-13  0:08           ` [Qemu-devel] [virtio-dev] " Samudrala, Sridhar
2018-06-14  1:02             ` Siwei Liu
2018-06-14 10:02               ` Cornelia Huck
2018-06-15  1:57                 ` Siwei Liu
2018-06-15 11:48                   ` Cornelia Huck
2018-06-15 17:06                     ` Siwei Liu
2018-06-19 10:54                       ` Cornelia Huck
2018-06-19 20:09                         ` Siwei Liu
2018-06-20 14:34                           ` Cornelia Huck
2018-06-20 19:59                             ` Siwei Liu
2018-06-19 20:32                         ` Michael S. Tsirkin
2018-06-20  9:53                           ` Cornelia Huck
2018-06-20 14:11                             ` Michael S. Tsirkin
2018-06-20 16:06                               ` Cornelia Huck
2018-06-20 19:48                                 ` Michael S. Tsirkin
2018-06-21 14:59                                   ` Cornelia Huck
2018-06-21 18:20                                     ` Michael S. Tsirkin
2018-06-22 15:09                                       ` Cornelia Huck
2018-06-22 19:05                                         ` Michael S. Tsirkin
2018-06-22 20:21                                           ` Siwei Liu
2018-06-22 21:32                                             ` Michael S. Tsirkin
2018-06-22 21:57                                               ` Siwei Liu
2018-06-22 22:33                                                 ` Michael S. Tsirkin
2018-06-23  0:05                                                   ` Siwei Liu
2018-06-26 15:08                                                     ` Cornelia Huck
2018-06-26 17:50                                                       ` Michael S. Tsirkin
2018-06-27  9:11                                                         ` Cornelia Huck
2018-06-25  9:55                                           ` Cornelia Huck
2018-06-26  1:46                                             ` Michael S. Tsirkin
2018-06-26 11:55                                               ` Cornelia Huck
2018-06-26 13:54                                                 ` Michael S. Tsirkin
2018-06-22 21:43                                         ` Michael S. Tsirkin
2018-06-27 10:10                                           ` Cornelia Huck
2018-06-22  1:21                                     ` Siwei Liu
2018-06-22  2:25                                       ` Venu Busireddy
2018-06-22  2:32                                       ` Michael S. Tsirkin
2018-06-22 20:00                                         ` Siwei Liu
2018-06-22 20:03                                           ` Siwei Liu
2018-06-22 21:29                                             ` Michael S. Tsirkin
2018-06-22 21:51                                               ` Siwei Liu
2018-06-22 22:25                                                 ` Michael S. Tsirkin
2018-06-22 23:40                                                   ` Siwei Liu
2018-06-23  0:17                                                     ` Siwei Liu
2018-06-24  1:45                                                       ` Michael S. Tsirkin
2018-06-25 17:54                                                       ` Samudrala, Sridhar
2018-06-26  1:50                                                         ` Michael S. Tsirkin
2018-06-26 15:17                                                           ` Cornelia Huck
2018-06-26 15:38                                                             ` Michael S. Tsirkin
2018-06-26 16:03                                                               ` Cornelia Huck
2018-06-26 17:42                                                                 ` Michael S. Tsirkin
2018-06-26 23:38                                                           ` Siwei Liu
2018-06-27  0:29                                                             ` Michael S. Tsirkin
2018-06-27  6:21                                                               ` Siwei Liu
2018-06-27  6:49                                                                 ` Samudrala, Sridhar
2018-06-27  7:03                                                                   ` Siwei Liu
2018-06-15  2:34                 ` Michael S. Tsirkin
2018-06-15  9:32                   ` Cornelia Huck
2018-06-15 12:31                     ` Michael S. Tsirkin
2018-06-18 13:27                       ` Cornelia Huck
2018-06-14 12:50               ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525734594-11134-1-git-send-email-sridhar.samudrala@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=aaron.f.brown@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=jasowang@redhat.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiri@resnulli.us \
    --cc=kubakici@wp.pl \
    --cc=loseweigh@gmail.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).