qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Chen <zhangckid@gmail.com>
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Zhang Chen <zhangckid@gmail.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH V7 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO
Date: Mon, 14 May 2018 11:23:41 +0800	[thread overview]
Message-ID: <1526268228-27951-11-git-send-email-zhangckid@gmail.com> (raw)
In-Reply-To: <1526268228-27951-1-git-send-email-zhangckid@gmail.com>

From: zhanghailiang <zhang.zhanghailiang@huawei.com>

If some errors happen during VM's COLO FT stage, it's important to
notify the users of this event. Together with 'x-colo-lost-heartbeat',
Users can intervene in COLO's failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necessary to notify users that we exited COLO mode.

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Signed-off-by: Zhang Chen <zhangckid@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 migration/colo.c    | 20 ++++++++++++++++++++
 qapi/migration.json | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+)

diff --git a/migration/colo.c b/migration/colo.c
index c083d36..8ca6381 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -28,6 +28,7 @@
 #include "net/colo-compare.h"
 #include "net/colo.h"
 #include "block/block.h"
+#include "qapi/qapi-events-migration.h"
 
 static bool vmstate_loading;
 static Notifier packets_compare_notifier;
@@ -514,6 +515,18 @@ out:
         qemu_fclose(fb);
     }
 
+    /*
+     * There are only two reasons we can go here, some error happened.
+     * Or the user triggered failover.
+     */
+    if (failover_get_state() == FAILOVER_STATUS_NONE) {
+        qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+                                  COLO_EXIT_REASON_ERROR, NULL);
+    } else {
+        qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+                                  COLO_EXIT_REASON_REQUEST, NULL);
+    }
+
     /* Hope this not to be too long to wait here */
     qemu_sem_wait(&s->colo_exit_sem);
     qemu_sem_destroy(&s->colo_exit_sem);
@@ -744,6 +757,13 @@ out:
     if (local_err) {
         error_report_err(local_err);
     }
+    if (failover_get_state() == FAILOVER_STATUS_NONE) {
+        qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+                                  COLO_EXIT_REASON_ERROR, NULL);
+    } else {
+        qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+                                  COLO_EXIT_REASON_REQUEST, NULL);
+    }
 
     if (fb) {
         qemu_fclose(fb);
diff --git a/qapi/migration.json b/qapi/migration.json
index f3974c6..55dae48 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -875,6 +875,43 @@
   'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
 
 ##
+# @COLO_EXIT:
+#
+# Emitted when VM finishes COLO mode due to some errors happening or
+# at the request of users.
+#
+# @mode: report COLO mode when COLO exited.
+#
+# @reason: describes the reason for the COLO exit.
+#
+# Since: 2.13
+#
+# Example:
+#
+# <- { "timestamp": {"seconds": 2032141960, "microseconds": 417172},
+#      "event": "COLO_EXIT", "data": {"mode": "primary", "reason": "request" } }
+#
+##
+{ 'event': 'COLO_EXIT',
+  'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
+
+##
+# @COLOExitReason:
+#
+# The reason for a COLO exit
+#
+# @none: no failover has ever happened.
+#
+# @request: COLO exit is due to an external request
+#
+# @error: COLO exit is due to an internal error
+#
+# Since: 2.13
+##
+{ 'enum': 'COLOExitReason',
+  'data': [ 'none', 'request', 'error' ] }
+
+##
 # @x-colo-lost-heartbeat:
 #
 # Tell qemu that heartbeat is lost, request it to do takeover procedures.
-- 
2.7.4

  parent reply	other threads:[~2018-05-14  6:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  3:23 [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block replication and COLO proxy Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 01/17] filter-rewriter: fix memory leak for connection in connection_track_table Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 02/17] colo-compare: implement the process of checkpoint Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 03/17] colo-compare: use notifier to notify packets comparing result Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 04/17] COLO: integrate colo compare with colo frame Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 05/17] COLO: Add block replication into colo process Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 06/17] COLO: Remove colo_state migration struct Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 07/17] COLO: Load dirty pages into SVM's RAM cache firstly Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 08/17] ram/COLO: Record the dirty pages that SVM received Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 09/17] COLO: Flush memory data from ram cache Zhang Chen
2018-05-14  3:23 ` Zhang Chen [this message]
2018-05-15 14:29   ` [Qemu-devel] [PATCH V7 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO Markus Armbruster
2018-05-16 13:41     ` Zhang Chen
2018-05-17  8:19       ` Markus Armbruster
2018-05-20 15:20         ` Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 11/17] qapi: Add new command to query colo status Zhang Chen
2018-05-15 14:26   ` Markus Armbruster
2018-05-16 13:14     ` Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 12/17] savevm: split the process of different stages for loadvm/savevm Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 13/17] COLO: flush host dirty ram from cache Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 14/17] filter: Add handle_event method for NetFilterClass Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 15/17] filter-rewriter: handle checkpoint and failover event Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 16/17] COLO: notify net filters about checkpoint/failover event Zhang Chen
2018-05-14  3:23 ` [Qemu-devel] [PATCH V7 17/17] COLO: quick failover process by kick COLO thread Zhang Chen
2018-05-14  6:57 ` [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block replication and COLO proxy no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526268228-27951-11-git-send-email-zhangckid@gmail.com \
    --to=zhangckid@gmail.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).