From: Jie Wang <wangjie88@huawei.com>
To: stefanha@redhat.com, eblake@redhat.com, peterx@redhat.com,
famz@redhat.com
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
eric.fangyi@huawei.com, wu.wubin@huawei.com
Subject: [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread
Date: Tue, 15 May 2018 20:00:43 +0800 [thread overview]
Message-ID: <1526385643-69675-1-git-send-email-wangjie88@huawei.com> (raw)
When we call addIOThread, the epollfd created in aio_context_setup,
but not close it in the process of delIOThread, so the epollfd will leak.
Signed-off-by: Jie Wang <wangjie88@huawei.com>
---
iothread.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/iothread.c b/iothread.c
index aff1281..23ac0a8 100644
--- a/iothread.c
+++ b/iothread.c
@@ -128,6 +128,7 @@ static void iothread_instance_finalize(Object *obj)
* GSources first before destroying any GMainContext.
*/
if (iothread->ctx) {
+ close(iothread->ctx->epollfd);
aio_context_unref(iothread->ctx);
iothread->ctx = NULL;
}
--
1.8.3.1
next reply other threads:[~2018-05-15 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 12:00 Jie Wang [this message]
2018-05-16 1:38 ` [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread Fam Zheng
2018-05-16 3:11 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526385643-69675-1-git-send-email-wangjie88@huawei.com \
--to=wangjie88@huawei.com \
--cc=eblake@redhat.com \
--cc=eric.fangyi@huawei.com \
--cc=famz@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).