* [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread
@ 2018-05-15 12:00 Jie Wang
2018-05-16 1:38 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Jie Wang @ 2018-05-15 12:00 UTC (permalink / raw)
To: stefanha, eblake, peterx, famz
Cc: qemu-devel, qemu-block, eric.fangyi, wu.wubin
When we call addIOThread, the epollfd created in aio_context_setup,
but not close it in the process of delIOThread, so the epollfd will leak.
Signed-off-by: Jie Wang <wangjie88@huawei.com>
---
iothread.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/iothread.c b/iothread.c
index aff1281..23ac0a8 100644
--- a/iothread.c
+++ b/iothread.c
@@ -128,6 +128,7 @@ static void iothread_instance_finalize(Object *obj)
* GSources first before destroying any GMainContext.
*/
if (iothread->ctx) {
+ close(iothread->ctx->epollfd);
aio_context_unref(iothread->ctx);
iothread->ctx = NULL;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread
2018-05-15 12:00 [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread Jie Wang
@ 2018-05-16 1:38 ` Fam Zheng
2018-05-16 3:11 ` Peter Xu
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2018-05-16 1:38 UTC (permalink / raw)
To: Jie Wang
Cc: stefanha, eblake, peterx, qemu-devel, qemu-block, eric.fangyi,
wu.wubin
On Tue, 05/15 20:00, Jie Wang wrote:
> When we call addIOThread, the epollfd created in aio_context_setup,
> but not close it in the process of delIOThread, so the epollfd will leak.
>
> Signed-off-by: Jie Wang <wangjie88@huawei.com>
> ---
> iothread.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/iothread.c b/iothread.c
> index aff1281..23ac0a8 100644
> --- a/iothread.c
> +++ b/iothread.c
> @@ -128,6 +128,7 @@ static void iothread_instance_finalize(Object *obj)
> * GSources first before destroying any GMainContext.
> */
> if (iothread->ctx) {
> + close(iothread->ctx->epollfd);
> aio_context_unref(iothread->ctx);
> iothread->ctx = NULL;
> }
> --
> 1.8.3.1
>
Please add an aio_context_destroy() function in aio-posix.c and call it from
aio_context_finalize(). IOThread code should not touch AioContext internals.
Also please remember to wrap the close() code in CONFIG_EPOLL_CREATE1. An empty
function may need to be added to aio-win32.c, too.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread
2018-05-16 1:38 ` Fam Zheng
@ 2018-05-16 3:11 ` Peter Xu
0 siblings, 0 replies; 3+ messages in thread
From: Peter Xu @ 2018-05-16 3:11 UTC (permalink / raw)
To: Fam Zheng
Cc: Jie Wang, stefanha, eblake, qemu-devel, qemu-block, eric.fangyi,
wu.wubin
On Wed, May 16, 2018 at 09:38:31AM +0800, Fam Zheng wrote:
> On Tue, 05/15 20:00, Jie Wang wrote:
> > When we call addIOThread, the epollfd created in aio_context_setup,
> > but not close it in the process of delIOThread, so the epollfd will leak.
> >
> > Signed-off-by: Jie Wang <wangjie88@huawei.com>
> > ---
> > iothread.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/iothread.c b/iothread.c
> > index aff1281..23ac0a8 100644
> > --- a/iothread.c
> > +++ b/iothread.c
> > @@ -128,6 +128,7 @@ static void iothread_instance_finalize(Object *obj)
> > * GSources first before destroying any GMainContext.
> > */
> > if (iothread->ctx) {
> > + close(iothread->ctx->epollfd);
> > aio_context_unref(iothread->ctx);
> > iothread->ctx = NULL;
> > }
> > --
> > 1.8.3.1
> >
>
> Please add an aio_context_destroy() function in aio-posix.c and call it from
> aio_context_finalize(). IOThread code should not touch AioContext internals.
I believe Fam means aio_ctx_finalize().
> Also please remember to wrap the close() code in CONFIG_EPOLL_CREATE1. An empty
> function may need to be added to aio-win32.c, too.
Agreed.
--
Peter Xu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-16 3:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-15 12:00 [Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread Jie Wang
2018-05-16 1:38 ` Fam Zheng
2018-05-16 3:11 ` Peter Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).