From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIcEh-0007IY-Ea for qemu-devel@nongnu.org; Tue, 15 May 2018 11:51:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIcEg-0000fA-O8 for qemu-devel@nongnu.org; Tue, 15 May 2018 11:51:35 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38420 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIcEg-0000eH-Jp for qemu-devel@nongnu.org; Tue, 15 May 2018 11:51:34 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D84C40200A3 for ; Tue, 15 May 2018 15:51:34 +0000 (UTC) From: Igor Mammedov Date: Tue, 15 May 2018 17:50:47 +0200 Message-Id: <1526399447-64923-1-git-send-email-imammedo@redhat.com> In-Reply-To: <20180515152641.7oaxop77wgzokr7h@kamzik.brq.redhat.com> References: <20180515152641.7oaxop77wgzokr7h@kamzik.brq.redhat.com> Subject: [Qemu-devel] [PATCH v3] numa: clarify error message when node index is out of range in -numa dist, ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: drjones@redhat.com, ehabkost@redhat.com When using following CLI: -numa dist,src=128,dst=1,val=20 user gets a rather confusing error message: "Invalid node 128, max possible could be 128" Where 128 is number of nodes that QEMU supports (MAX_NODES), while src/dst is an index up to that limit, so it should be MAX_NODES - 1 in error message. Make error message to explicitly state valid range for node index to be more clear. Signed-off-by: Igor Mammedov Reviewed-by: Andrew Jones --- v3: - s/,/./ in error message - add '.' at the end of sentence --- numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 188bfdf..d98c106 100644 --- a/numa.c +++ b/numa.c @@ -142,8 +142,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp) if (src >= MAX_NODES || dst >= MAX_NODES) { error_setg(errp, - "Invalid node %d, max possible could be %d", - MAX(src, dst), MAX_NODES); + "Invalid node %d. The valid node range is [0 - %d].", + MAX(src, dst), MAX_NODES - 1); return; } -- 2.7.4