qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] qapi/net.json: Fix the version number of the "vlan" removal
@ 2018-05-15 16:26 Thomas Huth
  2018-05-15 16:43 ` Eric Blake
  2018-05-21  2:58 ` Jason Wang
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2018-05-15 16:26 UTC (permalink / raw)
  To: qemu-devel, Jason Wang; +Cc: Eric Blake, qemu-trivial

"vlan" will be dropped in 2.13, not in 2.12. And while we're at it,
use the better wording "dropped in" instead of "removed with" (also
for the "dump" removal).

Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qapi/net.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/net.json b/qapi/net.json
index b4fe4b6..b8adf1f 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -450,7 +450,7 @@
 #
 # Since: 2.7
 #
-# 'dump' - removed with 2.12
+# 'dump': dropped in 2.12
 ##
 { 'enum': 'NetClientDriver',
   'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
@@ -498,7 +498,7 @@
 #
 # Since: 1.2
 #
-# 'vlan' - removed with 2.12
+# 'vlan': dropped in 2.13
 ##
 { 'struct': 'NetLegacy',
   'data': {
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] qapi/net.json: Fix the version number of the "vlan" removal
  2018-05-15 16:26 [Qemu-devel] [PATCH] qapi/net.json: Fix the version number of the "vlan" removal Thomas Huth
@ 2018-05-15 16:43 ` Eric Blake
  2018-05-21  2:58 ` Jason Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2018-05-15 16:43 UTC (permalink / raw)
  To: Thomas Huth, qemu-devel, Jason Wang; +Cc: qemu-trivial

On 05/15/2018 11:26 AM, Thomas Huth wrote:
> "vlan" will be dropped in 2.13, not in 2.12. And while we're at it,
> use the better wording "dropped in" instead of "removed with" (also
> for the "dump" removal).
> 
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   qapi/net.json | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] qapi/net.json: Fix the version number of the "vlan" removal
  2018-05-15 16:26 [Qemu-devel] [PATCH] qapi/net.json: Fix the version number of the "vlan" removal Thomas Huth
  2018-05-15 16:43 ` Eric Blake
@ 2018-05-21  2:58 ` Jason Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2018-05-21  2:58 UTC (permalink / raw)
  To: Thomas Huth, qemu-devel; +Cc: Eric Blake, qemu-trivial



On 2018年05月16日 00:26, Thomas Huth wrote:
> "vlan" will be dropped in 2.13, not in 2.12. And while we're at it,
> use the better wording "dropped in" instead of "removed with" (also
> for the "dump" removal).
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   qapi/net.json | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index b4fe4b6..b8adf1f 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -450,7 +450,7 @@
>   #
>   # Since: 2.7
>   #
> -# 'dump' - removed with 2.12
> +# 'dump': dropped in 2.12
>   ##
>   { 'enum': 'NetClientDriver',
>     'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
> @@ -498,7 +498,7 @@
>   #
>   # Since: 1.2
>   #
> -# 'vlan' - removed with 2.12
> +# 'vlan': dropped in 2.13
>   ##
>   { 'struct': 'NetLegacy',
>     'data': {

Applied.

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-21  2:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-15 16:26 [Qemu-devel] [PATCH] qapi/net.json: Fix the version number of the "vlan" removal Thomas Huth
2018-05-15 16:43 ` Eric Blake
2018-05-21  2:58 ` Jason Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).