From: "Emilio G. Cota" <cota@braap.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v3 16/17] translate-all: remove tb_lock mention from cpu_restore_state_from_tb
Date: Mon, 21 May 2018 19:39:26 -0400 [thread overview]
Message-ID: <1526945967-9687-17-git-send-email-cota@braap.org> (raw)
In-Reply-To: <1526945967-9687-1-git-send-email-cota@braap.org>
tb_lock was needed when the function did retranslation. However,
since fca8a500d519 ("tcg: Save insn data and use it in
cpu_restore_state_from_tb") we don't do retranslation.
Get rid of the comment.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
accel/tcg/translate-all.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 031060f..6cc7b94 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -355,7 +355,6 @@ static int encode_search(TranslationBlock *tb, uint8_t *block)
}
/* The cpu state corresponding to 'searched_pc' is restored.
- * Called with tb_lock held.
* When reset_icount is true, current TB will be interrupted and
* icount should be recalculated.
*/
--
2.7.4
next prev parent reply other threads:[~2018-05-21 23:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 23:39 [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3 Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 01/17] qht: require a default comparison function Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 02/17] qht: return existing entry when qht_insert fails Emilio G. Cota
2018-05-31 10:43 ` Alex Bennée
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 03/17] tcg: track TBs with per-region BST's Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 04/17] tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 05/17] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 06/17] translate-all: make l1_map lockless Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 07/17] translate-all: remove hole in PageDesc Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 08/17] translate-all: work page-by-page in tb_invalidate_phys_range_1 Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 09/17] translate-all: move tb_invalidate_phys_page_range up in the file Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 10/17] translate-all: use per-page locking in !user-mode Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 11/17] translate-all: add page_locked assertions Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 12/17] translate-all: introduce assert_no_pages_locked Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 13/17] translate-all: discard TB when tb_link_page returns an existing matching TB Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 14/17] translate-all: protect TB jumps with a per-destination-TB lock Emilio G. Cota
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 15/17] cputlb: remove tb_lock from tlb_flush functions Emilio G. Cota
2018-05-21 23:39 ` Emilio G. Cota [this message]
2018-05-21 23:39 ` [Qemu-devel] [PATCH v3 17/17] tcg: remove tb_lock Emilio G. Cota
2018-05-30 22:46 ` [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3 Richard Henderson
2018-05-30 23:05 ` Richard Henderson
2018-06-01 9:32 ` Alex Bennée
2018-06-01 14:55 ` Richard Henderson
2018-06-02 0:29 ` Emilio G. Cota
2018-06-02 8:38 ` Alex Bennée
2018-06-14 18:34 ` Alex Bennée
2018-06-14 19:36 ` Richard Henderson
2018-06-01 15:38 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526945967-9687-17-git-send-email-cota@braap.org \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).