[Qemu-devel] [PATCH] qemu-options: Mark the non-functional -clock option as deprecated

[Qemu-devel] [PATCH] qemu-options: Mark the non-functional -clock option as deprecated

[Thomas Huth]

The function is only ignored since QEMU version 1.7.0. Let's mark
it as deprecated, so that we can finally completely remove it soon.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-doc.texi | 5 +++++
 vl.c          | 1 +
 2 files changed, 6 insertions(+)

diff --git a/qemu-doc.texi b/qemu-doc.texi
index 0e0e0ae..057a48e 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2922,6 +2922,11 @@ The @code{-startdate} option has been replaced by @code{-rtc base=@var{date}}.
 Option @option{-virtioconsole} has been replaced by
 @option{-device virtconsole}.
 
+@subsection -clock (since 3.0.0)
+
+The @code{-clock} option is ignored since QEMU version 1.7.0. There is no
+replacement since it is not needed anymore.
+
 @section qemu-img command line arguments
 
 @subsection convert -s (since 2.0.0)
diff --git a/vl.c b/vl.c
index d5836c6..f7c0a46 100644
--- a/vl.c
+++ b/vl.c
@@ -3829,6 +3829,7 @@ int main(int argc, char **argv, char **envp)
                 /* Clock options no longer exist.  Keep this option for
                  * backward compatibility.
                  */
+                warn_report("This option is ignored and will be removed soon");
                 break;
             case QEMU_OPTION_startdate:
                 warn_report("This option is deprecated, use '-rtc base=' instead.");
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] qemu-options: Mark the non-functional -clock option as deprecated

[Paolo Bonzini]

On 22/05/2018 13:58, Thomas Huth wrote:
> The function is only ignored since QEMU version 1.7.0. Let's mark
> it as deprecated, so that we can finally completely remove it soon.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qemu-doc.texi | 5 +++++
>  vl.c          | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 0e0e0ae..057a48e 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2922,6 +2922,11 @@ The @code{-startdate} option has been replaced by @code{-rtc base=@var{date}}.
>  Option @option{-virtioconsole} has been replaced by
>  @option{-device virtconsole}.
>  
> +@subsection -clock (since 3.0.0)
> +
> +The @code{-clock} option is ignored since QEMU version 1.7.0. There is no
> +replacement since it is not needed anymore.
> +
>  @section qemu-img command line arguments
>  
>  @subsection convert -s (since 2.0.0)
> diff --git a/vl.c b/vl.c
> index d5836c6..f7c0a46 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3829,6 +3829,7 @@ int main(int argc, char **argv, char **envp)
>                  /* Clock options no longer exist.  Keep this option for
>                   * backward compatibility.
>                   */
> +                warn_report("This option is ignored and will be removed soon");
>                  break;
>              case QEMU_OPTION_startdate:
>                  warn_report("This option is deprecated, use '-rtc base=' instead.");
> 

Queued, thanks.

Paolo