From: Shannon Zhao <zhaoshenglong@huawei.com>
To: qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, eric.auger@redhat.com,
qemu-devel@nongnu.org, shannon.zhaosl@gmail.com
Subject: [Qemu-devel] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly
Date: Wed, 23 May 2018 11:53:52 +0800 [thread overview]
Message-ID: <1527047633-12368-1-git-send-email-zhaoshenglong@huawei.com> (raw)
It forgot to increase clroffset during the loop. So it only clear the
first 4 bytes.
Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920
Cc: qemu-stable@nongnu.org
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
Changes in V3: Add reviewed-by tag
---
hw/intc/arm_gicv3_kvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
index ec37177..3536795 100644
--- a/hw/intc/arm_gicv3_kvm.c
+++ b/hw/intc/arm_gicv3_kvm.c
@@ -243,6 +243,7 @@ static void kvm_dist_putbmp(GICv3State *s, uint32_t offset,
if (clroffset != 0) {
reg = 0;
kvm_gicd_access(s, clroffset, ®, true);
+ clroffset += 4;
}
reg = *gic_bmp_ptr32(bmp, irq);
kvm_gicd_access(s, offset, ®, true);
--
2.0.4
next reply other threads:[~2018-05-23 3:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 3:53 Shannon Zhao [this message]
2018-05-23 3:53 ` [Qemu-devel] [PATCH V3 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR Shannon Zhao
2018-05-24 9:04 ` Auger Eric
2018-05-24 9:20 ` Shannon Zhao
2018-05-24 12:10 ` Auger Eric
2018-05-24 13:14 ` Peter Maydell
2018-05-24 13:59 ` Auger Eric
2018-05-24 14:16 ` Peter Maydell
2018-05-24 14:40 ` Auger Eric
2018-05-24 14:56 ` Peter Maydell
2018-05-24 14:58 ` Peter Maydell
2018-05-24 15:09 ` Auger Eric
2018-05-25 8:42 ` Shannon Zhao
2018-05-25 9:00 ` Peter Maydell
2018-05-24 13:11 ` Peter Maydell
2018-05-25 9:15 ` Shannon Zhao
2018-05-24 12:38 ` [Qemu-devel] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527047633-12368-1-git-send-email-zhaoshenglong@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).