From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 00/20] include cleanups
Date: Fri, 25 May 2018 19:47:33 +0300 [thread overview]
Message-ID: <1527266793-301361-1-git-send-email-mst@redhat.com> (raw)
Right now, a local header can be included with either
#include "foo.h"
or
#include "dir/foo.h"
since the later doesn't tell you where the header is
(in source or include directory), the former is preferable.
I intend to look for ways to prevent the second way from working, but
that will take time. For now, fix all instances for the later way I
could find.
In a couple of places I just dropped the include instead.
Finally, arch_init huge list of includes is sorted, which will be
helpful in future cleanups.
This was part of the include path cleanup patchset
(https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg00739.html).
Changes from v1
drop patches not dealing with local headers
stop saying include through root works by accident -
it's not by accident, just not how we'd like code to look like
address comments by eric, philip, others
Michael S. Tsirkin (20):
block: use local path for local headers
crypto: use local path for local headers
hppa: use local path for local headers
migration: drop an unused include
trace: use local path for local headers
display: use local path for local headers
ide: use local path for local headers
ioapic: fix up includes
e1000e: use local path for local headers
rocker: drop an unused include
ppc: use local path for local headers
vhost-scsi: drop an unused include
sd: fix up include
usb: use local path for local headers
migration: use local path for local headers
colo: use local path for local headers
qga: use local path for local headers
trace: use local path for local headers
ui: use local path for local headers
arch_init: sort architectures
crypto/block-luks.h | 2 +-
crypto/block-qcow.h | 2 +-
crypto/ivgen-essiv.h | 2 +-
crypto/ivgen-plain.h | 2 +-
crypto/ivgen-plain64.h | 2 +-
hw/hppa/hppa_sys.h | 2 +-
include/migration/vmstate.h | 2 +-
trace/control.h | 2 +-
arch_init.c | 16 ++++++++--------
block/crypto.c | 2 +-
block/nbd.c | 2 +-
block/qcow.c | 2 +-
block/qcow2-bitmap.c | 2 +-
block/qcow2-cluster.c | 2 +-
block/qcow2-refcount.c | 2 +-
block/qcow2-snapshot.c | 2 +-
block/qcow2.c | 4 ++--
block/vhdx-endian.c | 2 +-
block/vhdx-log.c | 2 +-
block/vhdx.c | 2 +-
crypto/block-luks.c | 2 +-
crypto/block-qcow.c | 2 +-
crypto/block.c | 6 +++---
crypto/cipher.c | 6 +++---
crypto/ivgen-essiv.c | 2 +-
crypto/ivgen-plain.c | 2 +-
crypto/ivgen-plain64.c | 2 +-
crypto/ivgen.c | 8 ++++----
crypto/tlscreds.c | 2 +-
crypto/tlscredsanon.c | 2 +-
crypto/tlscredsx509.c | 2 +-
hw/display/bcm2835_fb.c | 2 +-
hw/hppa/machine.c | 2 +-
hw/ide/ahci-allwinner.c | 2 +-
hw/ide/ahci.c | 2 +-
hw/ide/ich.c | 2 +-
hw/intc/ioapic.c | 3 +--
hw/net/e1000e.c | 2 +-
hw/net/rocker/rocker_fp.c | 1 -
hw/ppc/ppc440_uc.c | 2 +-
hw/ppc/sam460ex.c | 4 ++--
hw/scsi/vhost-scsi-common.c | 1 -
hw/sd/milkymist-memcard.c | 2 +-
hw/usb/desc-msos.c | 2 +-
hw/usb/desc.c | 2 +-
hw/usb/dev-audio.c | 2 +-
hw/usb/dev-bluetooth.c | 2 +-
hw/usb/dev-hid.c | 2 +-
hw/usb/dev-hub.c | 2 +-
hw/usb/dev-mtp.c | 2 +-
hw/usb/dev-network.c | 2 +-
hw/usb/dev-serial.c | 2 +-
hw/usb/dev-smartcard-reader.c | 2 +-
hw/usb/dev-storage.c | 2 +-
hw/usb/dev-uas.c | 2 +-
hw/usb/dev-wacom.c | 2 +-
migration/block-dirty-bitmap.c | 2 +-
migration/page_cache.c | 2 +-
migration/ram.c | 4 ++--
migration/savevm.c | 1 +
migration/vmstate.c | 2 +-
net/colo-compare.c | 2 +-
net/colo.c | 2 +-
net/filter-rewriter.c | 2 +-
qga/channel-posix.c | 2 +-
qga/channel-win32.c | 4 ++--
qga/commands-posix.c | 2 +-
qga/commands-win32.c | 4 ++--
qga/commands.c | 2 +-
qga/guest-agent-command-state.c | 2 +-
qga/main.c | 4 ++--
qga/vss-win32.c | 6 +++---
trace/qmp.c | 2 +-
ui/gtk.c | 2 +-
ui/input-keymap.c | 2 +-
ui/input-legacy.c | 2 +-
ui/spice-input.c | 2 +-
77 files changed, 97 insertions(+), 99 deletions(-)
--
MST
next reply other threads:[~2018-05-25 16:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 16:47 Michael S. Tsirkin [this message]
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 01/20] block: use local path for local headers Michael S. Tsirkin
2018-05-25 18:25 ` Eric Blake
2018-05-25 21:41 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 02/20] crypto: " Michael S. Tsirkin
2018-05-25 21:40 ` Philippe Mathieu-Daudé
2018-06-01 12:22 ` Daniel P. Berrangé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 03/20] hppa: " Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include Michael S. Tsirkin
2018-05-25 18:27 ` Eric Blake
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 06/20] display: use local path for local headers Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 05/20] trace: " Michael S. Tsirkin
2018-05-25 21:29 ` Philippe Mathieu-Daudé
2018-05-25 21:49 ` Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 07/20] ide: " Michael S. Tsirkin
2018-05-25 21:39 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 09/20] e1000e: " Michael S. Tsirkin
2018-05-25 21:36 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes Michael S. Tsirkin
2018-05-25 21:37 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 10/20] rocker: drop an unused include Michael S. Tsirkin
2018-05-25 21:34 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 11/20] ppc: use local path for local headers Michael S. Tsirkin
2018-05-25 22:43 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 12/20] vhost-scsi: drop an unused include Michael S. Tsirkin
2018-05-26 4:29 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 13/20] sd: fix up include Michael S. Tsirkin
2018-05-25 21:31 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 14/20] usb: use local path for local headers Michael S. Tsirkin
2018-05-25 21:35 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 15/20] migration: " Michael S. Tsirkin
2018-05-25 18:24 ` Eric Blake
2018-05-25 20:56 ` Michael S. Tsirkin
2018-05-25 18:27 ` Juan Quintela
2018-05-25 20:57 ` Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 16/20] colo: " Michael S. Tsirkin
2018-05-26 4:31 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 17/20] qga: " Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 18/20] trace: " Michael S. Tsirkin
2018-05-25 21:32 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 19/20] ui: " Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 20/20] arch_init: sort architectures Michael S. Tsirkin
2018-05-28 11:13 ` Laszlo Ersek
2018-05-25 18:32 ` [Qemu-devel] [PATCH v2 00/20] include cleanups Eric Blake
2018-05-25 21:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527266793-301361-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).