qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ari Sundholm <ari@tuxera.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Ari Sundholm <ari@tuxera.com>
Subject: [Qemu-devel] [PATCH 3/5] hw/scsi/scsi-disk: Always apply block configuration to block driver
Date: Fri, 1 Jun 2018 00:17:21 +0300	[thread overview]
Message-ID: <1527801443-30620-3-git-send-email-ari@tuxera.com> (raw)
In-Reply-To: <1527801443-30620-2-git-send-email-ari@tuxera.com>

This is an example of what all block devices should ideally do in their
realization functions to convey the block configuration to the block
driver.

Signed-off-by: Ari Sundholm <ari@tuxera.com>
---
 hw/scsi/scsi-disk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index ded23d3..d50517e 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2413,6 +2413,7 @@ static void scsi_realize(SCSIDevice *dev, Error **errp)
         blk_set_dev_ops(s->qdev.conf.blk, &scsi_disk_block_ops, s);
     }
     blk_set_guest_block_size(s->qdev.conf.blk, s->qdev.blocksize);
+    blkconf_apply_to_blkdrv(&s->qdev.conf);
 
     blk_iostatus_enable(s->qdev.conf.blk);
 }
-- 
2.7.4

  reply	other threads:[~2018-05-31 21:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 21:17 [Qemu-devel] [PATCH 1/5] block: Add blklogwrites Ari Sundholm
2018-05-31 21:17 ` [Qemu-devel] [PATCH 2/5] block: Add a mechanism for passing a block driver a block configuration Ari Sundholm
2018-05-31 21:17   ` Ari Sundholm [this message]
2018-05-31 21:17     ` [Qemu-devel] [PATCH 4/5] block/blklogwrites: Use block limits from the backend " Ari Sundholm
2018-05-31 21:17       ` [Qemu-devel] [PATCH 5/5] block/blklogwrites: Use the block device logical sector size when logging writes Ari Sundholm
2018-06-01 12:26 ` [Qemu-devel] [PATCH 1/5] block: Add blklogwrites Eric Blake
2018-06-01 13:31   ` Ari Sundholm
2018-06-01 15:05     ` Eric Blake
2018-06-01 15:15       ` Ari Sundholm
2018-06-01 15:44         ` Eric Blake
2018-06-04  9:59   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-06-01 13:32 ` Stefan Hajnoczi
2018-06-01 14:24   ` Ari Sundholm
2018-06-04  9:51     ` Stefan Hajnoczi
2018-06-04 12:10       ` Ari Sundholm
2018-06-07 12:30         ` Stefan Hajnoczi
2018-06-07 13:13           ` Ari Sundholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527801443-30620-3-git-send-email-ari@tuxera.com \
    --to=ari@tuxera.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).