qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable
@ 2018-06-13  5:24 Thomas Huth
  2018-06-13 10:34 ` David Hildenbrand
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2018-06-13  5:24 UTC (permalink / raw)
  To: qemu-trivial, qemu-devel

These files can not be executed on the host, so they should not be
marked as executable.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 block/blkreplay.c                  |   0
 pc-bios/hppa-firmware.img          | Bin
 pc-bios/palcode-clipper            | Bin
 pc-bios/u-boot-sam460-20100605.bin | Bin
 pc-bios/u-boot.e500                | Bin
 replay/replay-char.c               |   0
 6 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 block/blkreplay.c
 mode change 100755 => 100644 pc-bios/hppa-firmware.img
 mode change 100755 => 100644 pc-bios/palcode-clipper
 mode change 100755 => 100644 pc-bios/u-boot-sam460-20100605.bin
 mode change 100755 => 100644 pc-bios/u-boot.e500
 mode change 100755 => 100644 replay/replay-char.c

diff --git a/block/blkreplay.c b/block/blkreplay.c
old mode 100755
new mode 100644
diff --git a/pc-bios/hppa-firmware.img b/pc-bios/hppa-firmware.img
old mode 100755
new mode 100644
diff --git a/pc-bios/palcode-clipper b/pc-bios/palcode-clipper
old mode 100755
new mode 100644
diff --git a/pc-bios/u-boot-sam460-20100605.bin b/pc-bios/u-boot-sam460-20100605.bin
old mode 100755
new mode 100644
diff --git a/pc-bios/u-boot.e500 b/pc-bios/u-boot.e500
old mode 100755
new mode 100644
diff --git a/replay/replay-char.c b/replay/replay-char.c
old mode 100755
new mode 100644
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable
  2018-06-13  5:24 [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable Thomas Huth
@ 2018-06-13 10:34 ` David Hildenbrand
  2018-08-24  5:05   ` Thomas Huth
  0 siblings, 1 reply; 3+ messages in thread
From: David Hildenbrand @ 2018-06-13 10:34 UTC (permalink / raw)
  To: Thomas Huth, qemu-trivial, qemu-devel

On 13.06.2018 07:24, Thomas Huth wrote:
> These files can not be executed on the host, so they should not be
> marked as executable.

Or can not be executed at all :)

Reviewed-by: David Hildenbrand <david@redhat.com>

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  block/blkreplay.c                  |   0
>  pc-bios/hppa-firmware.img          | Bin
>  pc-bios/palcode-clipper            | Bin
>  pc-bios/u-boot-sam460-20100605.bin | Bin
>  pc-bios/u-boot.e500                | Bin
>  replay/replay-char.c               |   0
>  6 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 block/blkreplay.c
>  mode change 100755 => 100644 pc-bios/hppa-firmware.img
>  mode change 100755 => 100644 pc-bios/palcode-clipper
>  mode change 100755 => 100644 pc-bios/u-boot-sam460-20100605.bin
>  mode change 100755 => 100644 pc-bios/u-boot.e500
>  mode change 100755 => 100644 replay/replay-char.c
> 
> diff --git a/block/blkreplay.c b/block/blkreplay.c
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/hppa-firmware.img b/pc-bios/hppa-firmware.img
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/palcode-clipper b/pc-bios/palcode-clipper
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/u-boot-sam460-20100605.bin b/pc-bios/u-boot-sam460-20100605.bin
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/u-boot.e500 b/pc-bios/u-boot.e500
> old mode 100755
> new mode 100644
> diff --git a/replay/replay-char.c b/replay/replay-char.c
> old mode 100755
> new mode 100644
> 


-- 

Thanks,

David / dhildenb

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable
  2018-06-13 10:34 ` David Hildenbrand
@ 2018-08-24  5:05   ` Thomas Huth
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2018-08-24  5:05 UTC (permalink / raw)
  To: Michael Tokarev, qemu-trivial; +Cc: qemu-devel, Laurent Vivier

On 2018-06-13 12:34, David Hildenbrand wrote:
> On 13.06.2018 07:24, Thomas Huth wrote:
>> These files can not be executed on the host, so they should not be
>> marked as executable.
> 
> Or can not be executed at all :)
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>
> 
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  block/blkreplay.c                  |   0
>>  pc-bios/hppa-firmware.img          | Bin
>>  pc-bios/palcode-clipper            | Bin
>>  pc-bios/u-boot-sam460-20100605.bin | Bin
>>  pc-bios/u-boot.e500                | Bin
>>  replay/replay-char.c               |   0
>>  6 files changed, 0 insertions(+), 0 deletions(-)
>>  mode change 100755 => 100644 block/blkreplay.c
>>  mode change 100755 => 100644 pc-bios/hppa-firmware.img
>>  mode change 100755 => 100644 pc-bios/palcode-clipper
>>  mode change 100755 => 100644 pc-bios/u-boot-sam460-20100605.bin
>>  mode change 100755 => 100644 pc-bios/u-boot.e500
>>  mode change 100755 => 100644 replay/replay-char.c
>>
>> diff --git a/block/blkreplay.c b/block/blkreplay.c
>> old mode 100755
>> new mode 100644
>> diff --git a/pc-bios/hppa-firmware.img b/pc-bios/hppa-firmware.img
>> old mode 100755
>> new mode 100644
>> diff --git a/pc-bios/palcode-clipper b/pc-bios/palcode-clipper
>> old mode 100755
>> new mode 100644
>> diff --git a/pc-bios/u-boot-sam460-20100605.bin b/pc-bios/u-boot-sam460-20100605.bin
>> old mode 100755
>> new mode 100644
>> diff --git a/pc-bios/u-boot.e500 b/pc-bios/u-boot.e500
>> old mode 100755
>> new mode 100644
>> diff --git a/replay/replay-char.c b/replay/replay-char.c
>> old mode 100755
>> new mode 100644

Ping?

 Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-24  5:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-13  5:24 [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable Thomas Huth
2018-06-13 10:34 ` David Hildenbrand
2018-08-24  5:05   ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).