From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
armbru@redhat.com, jsnow@redhat.com, pbonzini@redhat.com,
eblake@redhat.com, berto@igalia.com, den@virtuozzo.com,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields
Date: Wed, 13 Jun 2018 20:44:19 +0300 [thread overview]
Message-ID: <1528911866-37489-2-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1528911866-37489-1-git-send-email-anton.nefedov@virtuozzo.com>
Make the stat fields definition slightly more readable.
Also reorder total_time_ns stats read-write-flush as done elsewhere.
Cosmetic change only.
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
---
qapi/block-core.json | 34 +++++++++++++++++++++++-----------
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index b3e94d8..ee75aef 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -784,12 +784,12 @@
# @flush_operations: The number of cache flush operations performed by the
# device (since 0.15.0)
#
-# @flush_total_time_ns: Total time spend on cache flushes in nano-seconds
-# (since 0.15.0).
+# @rd_total_time_ns: Total time spent on reads in nanoseconds (since 0.15.0).
#
-# @wr_total_time_ns: Total time spend on writes in nano-seconds (since 0.15.0).
+# @wr_total_time_ns: Total time spent on writes in nanoseconds (since 0.15.0).
#
-# @rd_total_time_ns: Total_time_spend on reads in nano-seconds (since 0.15.0).
+# @flush_total_time_ns: Total time spent on cache flushes in nanoseconds
+# (since 0.15.0).
#
# @wr_highest_offset: The offset after the greatest byte written to the
# device. The intended use of this information is for
@@ -842,14 +842,26 @@
# Since: 0.14.0
##
{ 'struct': 'BlockDeviceStats',
- 'data': {'rd_bytes': 'int', 'wr_bytes': 'int', 'rd_operations': 'int',
- 'wr_operations': 'int', 'flush_operations': 'int',
- 'flush_total_time_ns': 'int', 'wr_total_time_ns': 'int',
- 'rd_total_time_ns': 'int', 'wr_highest_offset': 'int',
- 'rd_merged': 'int', 'wr_merged': 'int', '*idle_time_ns': 'int',
+ 'data': {'rd_bytes': 'int', 'wr_bytes': 'int',
+
+ 'rd_operations': 'int', 'wr_operations': 'int',
+ 'flush_operations': 'int',
+
+ 'rd_total_time_ns': 'int', 'wr_total_time_ns': 'int',
+ 'flush_total_time_ns': 'int',
+
+ 'wr_highest_offset': 'int',
+
+ 'rd_merged': 'int', 'wr_merged': 'int',
+
+ '*idle_time_ns': 'int',
+
'failed_rd_operations': 'int', 'failed_wr_operations': 'int',
- 'failed_flush_operations': 'int', 'invalid_rd_operations': 'int',
- 'invalid_wr_operations': 'int', 'invalid_flush_operations': 'int',
+ 'failed_flush_operations': 'int',
+
+ 'invalid_rd_operations': 'int', 'invalid_wr_operations': 'int',
+ 'invalid_flush_operations': 'int',
+
'account_invalid': 'bool', 'account_failed': 'bool',
'timed_stats': ['BlockDeviceTimedStats'],
'*x_rd_latency_histogram': 'BlockLatencyHistogramInfo',
--
2.7.4
next prev parent reply other threads:[~2018-06-13 17:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 17:44 [Qemu-devel] [PATCH v3 0/8] discard blockstats Anton Nefedov
2018-06-13 17:44 ` Anton Nefedov [this message]
2018-06-15 12:58 ` [Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields Alberto Garcia
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 2/8] qapi: add unmap to BlockDeviceStats Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 3/8] ide: account UNMAP (TRIM) operations Anton Nefedov
2018-06-15 13:04 ` Alberto Garcia
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 4/8] scsi: store unmap offset and nb_sectors in request struct Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 5/8] scsi: move unmap error checking to the complete callback Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 6/8] scsi: account unmap operations Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 7/8] file-posix: account discard operations Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 8/8] qapi: query-blockstat: add driver specific file-posix stats Anton Nefedov
2018-06-13 18:29 ` [Qemu-devel] [PATCH v3 0/8] discard blockstats no-reply
2018-06-13 18:44 ` no-reply
2018-06-14 6:44 ` Anton Nefedov
2018-06-15 15:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528911866-37489-2-git-send-email-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).