From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
armbru@redhat.com, jsnow@redhat.com, pbonzini@redhat.com,
eblake@redhat.com, berto@igalia.com, den@virtuozzo.com,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v3 6/8] scsi: account unmap operations
Date: Wed, 13 Jun 2018 20:44:24 +0300 [thread overview]
Message-ID: <1528911866-37489-7-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1528911866-37489-1-git-send-email-anton.nefedov@virtuozzo.com>
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
hw/scsi/scsi-disk.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 0b68a8d..ed72662 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1653,6 +1653,10 @@ static void scsi_unmap_complete_noio(UnmapCBData *data, int ret)
goto done;
}
+ block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct,
+ r->sector_count * s->qdev.blocksize,
+ BLOCK_ACCT_UNMAP);
+
r->req.aiocb = blk_aio_pdiscard(s->qdev.conf.blk,
r->sector * s->qdev.blocksize,
r->sector_count * s->qdev.blocksize,
@@ -1679,10 +1683,11 @@ static void scsi_unmap_complete(void *opaque, int ret)
r->req.aiocb = NULL;
aio_context_acquire(blk_get_aio_context(s->qdev.conf.blk));
- if (scsi_disk_req_check_error(r, ret, false)) {
+ if (scsi_disk_req_check_error(r, ret, true)) {
scsi_req_unref(&r->req);
g_free(data);
} else {
+ block_acct_done(blk_get_stats(s->qdev.conf.blk), &r->acct);
scsi_unmap_complete_noio(data, ret);
}
aio_context_release(blk_get_aio_context(s->qdev.conf.blk));
@@ -1729,10 +1734,12 @@ static void scsi_disk_emulate_unmap(SCSIDiskReq *r, uint8_t *inbuf)
return;
invalid_param_len:
+ block_acct_invalid(blk_get_stats(s->qdev.conf.blk), BLOCK_ACCT_UNMAP);
scsi_check_condition(r, SENSE_CODE(INVALID_PARAM_LEN));
return;
invalid_field:
+ block_acct_invalid(blk_get_stats(s->qdev.conf.blk), BLOCK_ACCT_UNMAP);
scsi_check_condition(r, SENSE_CODE(INVALID_FIELD));
}
--
2.7.4
next prev parent reply other threads:[~2018-06-13 17:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 17:44 [Qemu-devel] [PATCH v3 0/8] discard blockstats Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields Anton Nefedov
2018-06-15 12:58 ` Alberto Garcia
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 2/8] qapi: add unmap to BlockDeviceStats Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 3/8] ide: account UNMAP (TRIM) operations Anton Nefedov
2018-06-15 13:04 ` Alberto Garcia
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 4/8] scsi: store unmap offset and nb_sectors in request struct Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 5/8] scsi: move unmap error checking to the complete callback Anton Nefedov
2018-06-13 17:44 ` Anton Nefedov [this message]
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 7/8] file-posix: account discard operations Anton Nefedov
2018-06-13 17:44 ` [Qemu-devel] [PATCH v3 8/8] qapi: query-blockstat: add driver specific file-posix stats Anton Nefedov
2018-06-13 18:29 ` [Qemu-devel] [PATCH v3 0/8] discard blockstats no-reply
2018-06-13 18:44 ` no-reply
2018-06-14 6:44 ` Anton Nefedov
2018-06-15 15:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528911866-37489-7-git-send-email-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).