qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	peter.maydell@linaro.org, shameerali.kolothum.thodi@huawei.com,
	kwangwoo.lee@sk.com, imammedo@redhat.com, david@redhat.com
Cc: dgilbert@redhat.com, agraf@suse.de, david@gibson.dropbear.id.au,
	drjones@redhat.com, wei@redhat.com
Subject: [Qemu-devel] [RFC v2 14/15] hw/arm/boot: Expose the pmem nodes in the DT
Date: Mon,  2 Jul 2018 19:22:41 +0200	[thread overview]
Message-ID: <1530552162-15533-15-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1530552162-15533-1-git-send-email-eric.auger@redhat.com>

In case of NV-DIMM slots, let's add /pmem DT nodes.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 hw/arm/boot.c | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 2c7d558..3381c66 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -444,6 +444,36 @@ out:
     return ret;
 }
 
+static int fdt_add_pmem_node(void *fdt, uint32_t acells, hwaddr mem_base,
+                             uint32_t scells, hwaddr mem_len,
+                             int numa_node_id)
+{
+    char *nodename = NULL;
+    int ret;
+
+    nodename = g_strdup_printf("/pmem@%" PRIx64, mem_base);
+    qemu_fdt_add_subnode(fdt, nodename);
+    qemu_fdt_setprop_string(fdt, nodename, "compatible", "pmem-region");
+    ret = qemu_fdt_setprop_sized_cells(fdt, nodename, "reg", acells, mem_base,
+                                       scells, mem_len);
+    if (ret < 0) {
+        fprintf(stderr, "couldn't set %s/reg\n", nodename);
+        goto out;
+    }
+    if (numa_node_id < 0) {
+        goto out;
+    }
+
+    ret = qemu_fdt_setprop_cell(fdt, nodename, "numa-node-id", numa_node_id);
+    if (ret < 0) {
+        fprintf(stderr, "couldn't set %s/numa-node-id\n", nodename);
+    }
+
+out:
+    g_free(nodename);
+    return ret;
+}
+
 static void fdt_add_psci_node(void *fdt)
 {
     uint32_t cpu_suspend_fn;
@@ -532,7 +562,8 @@ static int fdt_add_hotpluggable_memory_nodes(void *fdt,
         di = !is_nvdimm ? mi->u.dimm.data : mi->u.nvdimm.data;
 
         if (is_nvdimm) {
-            ret = -ENOENT; /* NV-DIMM not yet supported */
+            ret = fdt_add_pmem_node(fdt, acells, di->addr,
+                                    scells, di->size, di->node);
         } else {
             ret = fdt_add_memory_node(fdt, acells, di->addr,
                                       scells, di->size, di->node);
-- 
2.5.5

  parent reply	other threads:[~2018-07-02 17:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 17:22 [Qemu-devel] [RFC v2 00/15] ARM virt: PCDIMM/NVDIMM at 2TB Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 01/15] linux-headers: header update for KVM/ARM KVM_ARM_GET_MAX_VM_PHYS_SHIFT Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 02/15] hw/boards: Add a MachineState parameter to kvm_type callback Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 03/15] kvm: add kvm_arm_get_max_vm_phys_shift Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 04/15] hw/arm/virt: support kvm_type property Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 05/15] hw/arm/virt: handle max_vm_phys_shift conflicts on migration Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 06/15] hw/arm/virt: Allocate device_memory Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 07/15] hw/arm/virt: Add memory hotplug framework Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 08/15] hw/arm/boot: introduce fdt_add_memory_node helper Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 09/15] hw/arm/boot: Expose the PC-DIMM nodes in the DT Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 10/15] acpi: move build_srat_hotpluggable_memory to generic ACPI source Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 11/15] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 12/15] nvdimm: use configurable ACPI IO base and size Eric Auger
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 13/15] hw/arm/virt: Add nvdimm hot-plug infrastructure Eric Auger
2018-07-02 17:22 ` Eric Auger [this message]
2018-07-02 17:22 ` [Qemu-devel] [RFC v2 15/15] hw/arm/virt: Add nvdimm and nvdimm-persistence options Eric Auger
2018-07-03  2:20 ` [Qemu-devel] [RFC v2 00/15] ARM virt: PCDIMM/NVDIMM at 2TB no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530552162-15533-15-git-send-email-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=kwangwoo.lee@sk.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).