qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check
@ 2018-07-02 22:02 Emilio G. Cota
  2018-07-03  1:03 ` [Qemu-devel] [Qemu-ppc] " David Gibson
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Emilio G. Cota @ 2018-07-02 22:02 UTC (permalink / raw)
  To: qemu-devel; +Cc: Richard Henderson, Mark Cave-Ayland, qemu-ppc

The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert
to TranslatorOps", 2018-02-16).

Fix it by setting is_jmp, so that we break from the translation loop
as originally intended.

Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
(I'll send this to qemu-stable (for 2.12) once it's on master.)
---
 target/ppc/translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 3a215a1..99c2731 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -7314,6 +7314,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase *dcbase, CPUState *cs,
     DisasContext *ctx = container_of(dcbase, DisasContext, base);
 
     gen_debug_exception(ctx);
+    dcbase->is_jmp = DISAS_NORETURN;
     /* The address covered by the breakpoint must be included in
        [tb->pc, tb->pc + tb->size) in order to for it to be
        properly cleared -- thus we increment the PC here so that
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-04 19:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 22:02 [Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check Emilio G. Cota
2018-07-03  1:03 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2018-07-03  3:22   ` Emilio G. Cota
2018-07-03  3:31     ` David Gibson
2018-07-03  3:42 ` [Qemu-devel] " no-reply
2018-07-04 19:53 ` [Qemu-devel] [PATCH for-2.12.1] " Emilio G. Cota

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).