[Qemu-devel] [PATCH] ui/sdl2: Fix broken -full-screen CLI option

[Qemu-devel] [PATCH] ui/sdl2: Fix broken -full-screen CLI option

[Thomas Huth]

We've got to set the gui_fullscreen variable before creating the
SDL2 window, otherwise the initial window will not be created in
fullscreen mode.

Buglink: https://bugs.launchpad.net/bugs/1780812
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 ui/sdl2.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/ui/sdl2.c b/ui/sdl2.c
index 76e5942..01571dc 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -792,6 +792,8 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
     memset(&info, 0, sizeof(info));
     SDL_VERSION(&info.version);
 
+    gui_fullscreen = o->has_full_screen && o->full_screen;
+
     for (i = 0;; i++) {
         QemuConsole *con = qemu_console_lookup_by_index(i);
         if (!con) {
@@ -844,17 +846,14 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
         g_free(filename);
     }
 
-    if (sdl2_console->opts->has_full_screen &&
-        sdl2_console->opts->full_screen) {
-        gui_fullscreen = 1;
+    gui_grab = 0;
+    if (gui_fullscreen) {
         sdl_grab_start(0);
     }
 
     mouse_mode_notifier.notify = sdl_mouse_mode_change;
     qemu_add_mouse_mode_change_notifier(&mouse_mode_notifier);
 
-    gui_grab = 0;
-
     sdl_cursor_hidden = SDL_CreateCursor(&data, &data, 8, 1, 0, 0);
     sdl_cursor_normal = SDL_GetCursor();
 
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] ui/sdl2: Fix broken -full-screen CLI option

[Thomas Huth]

On 2018-07-09 20:44, Thomas Huth wrote:
> We've got to set the gui_fullscreen variable before creating the
> SDL2 window, otherwise the initial window will not be created in
> fullscreen mode.
> 
> Buglink: https://bugs.launchpad.net/bugs/1780812
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  ui/sdl2.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index 76e5942..01571dc 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -792,6 +792,8 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
>      memset(&info, 0, sizeof(info));
>      SDL_VERSION(&info.version);
>  
> +    gui_fullscreen = o->has_full_screen && o->full_screen;
> +
>      for (i = 0;; i++) {
>          QemuConsole *con = qemu_console_lookup_by_index(i);
>          if (!con) {
> @@ -844,17 +846,14 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
>          g_free(filename);
>      }
>  
> -    if (sdl2_console->opts->has_full_screen &&
> -        sdl2_console->opts->full_screen) {
> -        gui_fullscreen = 1;
> +    gui_grab = 0;
> +    if (gui_fullscreen) {
>          sdl_grab_start(0);
>      }
>  
>      mouse_mode_notifier.notify = sdl_mouse_mode_change;
>      qemu_add_mouse_mode_change_notifier(&mouse_mode_notifier);
>  
> -    gui_grab = 0;
> -
>      sdl_cursor_hidden = SDL_CreateCursor(&data, &data, 8, 1, 0, 0);
>      sdl_cursor_normal = SDL_GetCursor();
>  
> 

Ping?

 Thomas

Re: [Qemu-devel] [PATCH] ui/sdl2: Fix broken -full-screen CLI option

[Gerd Hoffmann]

On Mon, Jul 09, 2018 at 08:44:10PM +0200, Thomas Huth wrote:
> We've got to set the gui_fullscreen variable before creating the
> SDL2 window, otherwise the initial window will not be created in
> fullscreen mode.

Added to ui queue.

thanks,
  Gerd