* [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default
@ 2018-07-18 15:08 Thomas Huth
2018-07-18 15:29 ` [Qemu-devel] [Qemu-block] " John Snow
2018-07-23 14:08 ` [Qemu-devel] " Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2018-07-18 15:08 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: Max Reitz, qemu-devel
It's annoying to see this debug message every time you use vvfat.
Disable it with the DLOG() macro by default, as it is done with the
other debug messages in this file.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
block/vvfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index c7d2ed2..fc41841 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1245,8 +1245,8 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
s->fat2 = NULL;
s->downcase_short_names = 1;
- fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
- dirname, cyls, heads, secs);
+ DLOG(fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
+ dirname, cyls, heads, secs));
s->sector_count = cyls * heads * secs - s->offset_to_bootsector;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] block/vvfat: Disable debug message by default
2018-07-18 15:08 [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default Thomas Huth
@ 2018-07-18 15:29 ` John Snow
2018-07-23 14:08 ` [Qemu-devel] " Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2018-07-18 15:29 UTC (permalink / raw)
To: Thomas Huth, Kevin Wolf, qemu-block; +Cc: qemu-devel, Max Reitz
On 07/18/2018 11:08 AM, Thomas Huth wrote:
> It's annoying to see this debug message every time you use vvfat.
> Disable it with the DLOG() macro by default, as it is done with the
> other debug messages in this file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> block/vvfat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index c7d2ed2..fc41841 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1245,8 +1245,8 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
> s->fat2 = NULL;
> s->downcase_short_names = 1;
>
> - fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
> - dirname, cyls, heads, secs);
> + DLOG(fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
> + dirname, cyls, heads, secs));
>
> s->sector_count = cyls * heads * secs - s->offset_to_bootsector;
>
>
Makes sense as a minimal change without doing more... real work here.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default
2018-07-18 15:08 [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default Thomas Huth
2018-07-18 15:29 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2018-07-23 14:08 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2018-07-23 14:08 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-block, Max Reitz, qemu-devel
Am 18.07.2018 um 17:08 hat Thomas Huth geschrieben:
> It's annoying to see this debug message every time you use vvfat.
> Disable it with the DLOG() macro by default, as it is done with the
> other debug messages in this file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-23 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 15:08 [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default Thomas Huth
2018-07-18 15:29 ` [Qemu-devel] [Qemu-block] " John Snow
2018-07-23 14:08 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).