From: Lidong Chen <jemmy858585@gmail.com>
To: quintela@redhat.com, dgilbert@redhat.com
Cc: qemu-devel@nongnu.org, Lidong Chen <lidongchen@tencent.com>
Subject: [Qemu-devel] [PATCH 1/2] migration: fix the Unknown ending state error log
Date: Tue, 24 Jul 2018 20:16:24 +0800 [thread overview]
Message-ID: <1532434585-14732-1-git-send-email-lidongchen@tencent.com> (raw)
When cancelling migration, the state is MIGRATION_STATUS_CANCELLING.
The state change to MIGRATION_STATUS_CANCELLED when cleanup_bh is scheduled.
So when migration_iteration_finish is invoked, the state should be
MIGRATION_STATUS_CANCELLING.
Signed-off-by: Lidong Chen <lidongchen@tencent.com>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 8d56d56..ff05422 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2876,7 +2876,7 @@ static void migration_iteration_finish(MigrationState *s)
s->vm_was_running = true;
/* Fallthrough */
case MIGRATION_STATUS_FAILED:
- case MIGRATION_STATUS_CANCELLED:
+ case MIGRATION_STATUS_CANCELLING:
if (s->vm_was_running) {
vm_start();
} else {
--
1.8.3.1
next reply other threads:[~2018-07-24 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 12:16 Lidong Chen [this message]
2018-07-24 12:16 ` [Qemu-devel] [PATCH 2/2] migration: fix duplicate initialization for expected_downtime and cleanup_bh Lidong Chen
2018-07-24 13:07 ` Peter Xu
2018-07-24 13:33 ` Juan Quintela
2018-07-24 16:28 ` Dr. David Alan Gilbert
2018-07-24 13:02 ` [Qemu-devel] [PATCH 1/2] migration: fix the Unknown ending state error log Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532434585-14732-1-git-send-email-lidongchen@tencent.com \
--to=jemmy858585@gmail.com \
--cc=dgilbert@redhat.com \
--cc=lidongchen@tencent.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).