qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lidong Chen <jemmy858585@gmail.com>
To: zhang.zhanghailiang@huawei.com, quintela@redhat.com, dgilbert@redhat.com
Cc: qemu-devel@nongnu.org, Lidong Chen <jemmy858585@gmail.com>,
	Lidong Chen <lidongchen@tencent.com>
Subject: [Qemu-devel] [PATCH v6 01/12] migration: disable RDMA WRITE after postcopy started
Date: Fri,  3 Aug 2018 17:13:39 +0800	[thread overview]
Message-ID: <1533287630-4221-2-git-send-email-lidongchen@tencent.com> (raw)
In-Reply-To: <1533287630-4221-1-git-send-email-lidongchen@tencent.com>

From: Lidong Chen <jemmy858585@gmail.com>

RDMA WRITE operations are performed with no notification to the destination
qemu, then the destination qemu can not wakeup. This patch disable RDMA WRITE
after postcopy started.

Signed-off-by: Lidong Chen <lidongchen@tencent.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/qemu-file.c |  8 ++++++--
 migration/rdma.c      | 12 ++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 0463f4c..977b9ae 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -253,8 +253,12 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset,
     if (f->hooks && f->hooks->save_page) {
         int ret = f->hooks->save_page(f, f->opaque, block_offset,
                                       offset, size, bytes_sent);
-        f->bytes_xfer += size;
-        if (ret != RAM_SAVE_CONTROL_DELAYED) {
+        if (ret != RAM_SAVE_CONTROL_NOT_SUPP) {
+            f->bytes_xfer += size;
+        }
+
+        if (ret != RAM_SAVE_CONTROL_DELAYED &&
+            ret != RAM_SAVE_CONTROL_NOT_SUPP) {
             if (bytes_sent && *bytes_sent > 0) {
                 qemu_update_position(f, *bytes_sent);
             } else if (ret < 0) {
diff --git a/migration/rdma.c b/migration/rdma.c
index 8bd7159..76424a5 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2921,6 +2921,10 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void *opaque,
 
     CHECK_ERROR_STATE();
 
+    if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+        return RAM_SAVE_CONTROL_NOT_SUPP;
+    }
+
     qemu_fflush(f);
 
     if (size > 0) {
@@ -3480,6 +3484,10 @@ static int qemu_rdma_registration_start(QEMUFile *f, void *opaque,
 
     CHECK_ERROR_STATE();
 
+    if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+        return 0;
+    }
+
     trace_qemu_rdma_registration_start(flags);
     qemu_put_be64(f, RAM_SAVE_FLAG_HOOK);
     qemu_fflush(f);
@@ -3502,6 +3510,10 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void *opaque,
 
     CHECK_ERROR_STATE();
 
+    if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+        return 0;
+    }
+
     qemu_fflush(f);
     ret = qemu_rdma_drain_cq(f, rdma);
 
-- 
1.8.3.1

  reply	other threads:[~2018-08-03  9:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  9:13 [Qemu-devel] [PATCH v6 00/12] Enable postcopy RDMA live migration Lidong Chen
2018-08-03  9:13 ` Lidong Chen [this message]
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 02/12] migration: create a dedicated connection for rdma return path Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 03/12] migration: avoid concurrent invoke channel_close by different threads Lidong Chen
2018-08-06  9:07   ` 858585 jemmy
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 04/12] migration: implement bi-directional RDMA QIOChannel Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 05/12] migration: Stop rdma yielding during incoming postcopy Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 06/12] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 07/12] migration: invoke qio_channel_yield only when qemu_in_coroutine() Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 08/12] migration: poll the cm event while wait RDMA work request completion Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 09/12] migration: implement the shutdown for RDMA QIOChannel Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 10/12] migration: poll the cm event for destination qemu Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 11/12] migration: remove the unnecessary RDMA_CONTROL_ERROR message Lidong Chen
2018-08-03  9:13 ` [Qemu-devel] [PATCH v6 12/12] migration: create a dedicated thread to release rdma resource Lidong Chen
2018-08-03  9:42 ` [Qemu-devel] [PATCH v6 00/12] Enable postcopy RDMA live migration no-reply
2018-08-06  6:09 ` 858585 jemmy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533287630-4221-2-git-send-email-lidongchen@tencent.com \
    --to=jemmy858585@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=lidongchen@tencent.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).