* [Qemu-devel] [PATCH] hw: edu: replace device name with macro
@ 2018-09-14 5:11 Li Qiang
2018-09-14 15:09 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Li Qiang @ 2018-09-14 5:11 UTC (permalink / raw)
To: jslaby, pbonzini; +Cc: qemu-devel, Li Qiang
Just as other devices do.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
hw/misc/edu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index df26a4d046..0687ffd343 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -30,7 +30,8 @@
#include "qemu/main-loop.h" /* iothread mutex */
#include "qapi/visitor.h"
-#define EDU(obj) OBJECT_CHECK(EduState, obj, "edu")
+#define TYPE_PCI_EDU_DEVICE "edu"
+#define EDU(obj) OBJECT_CHECK(EduState, obj, TYPE_PCI_EDU_DEVICE)
#define FACT_IRQ 0x00000001
#define DMA_IRQ 0x00000100
@@ -414,7 +415,7 @@ static void pci_edu_register_types(void)
{ },
};
static const TypeInfo edu_info = {
- .name = "edu",
+ .name = TYPE_PCI_EDU_DEVICE,
.parent = TYPE_PCI_DEVICE,
.instance_size = sizeof(EduState),
.instance_init = edu_instance_init,
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] hw: edu: replace device name with macro
2018-09-14 5:11 [Qemu-devel] [PATCH] hw: edu: replace device name with macro Li Qiang
@ 2018-09-14 15:09 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2018-09-14 15:09 UTC (permalink / raw)
To: Li Qiang, jslaby; +Cc: qemu-devel
On 14/09/2018 07:11, Li Qiang wrote:
> Just as other devices do.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> hw/misc/edu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index df26a4d046..0687ffd343 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -30,7 +30,8 @@
> #include "qemu/main-loop.h" /* iothread mutex */
> #include "qapi/visitor.h"
>
> -#define EDU(obj) OBJECT_CHECK(EduState, obj, "edu")
> +#define TYPE_PCI_EDU_DEVICE "edu"
> +#define EDU(obj) OBJECT_CHECK(EduState, obj, TYPE_PCI_EDU_DEVICE)
>
> #define FACT_IRQ 0x00000001
> #define DMA_IRQ 0x00000100
> @@ -414,7 +415,7 @@ static void pci_edu_register_types(void)
> { },
> };
> static const TypeInfo edu_info = {
> - .name = "edu",
> + .name = TYPE_PCI_EDU_DEVICE,
> .parent = TYPE_PCI_DEVICE,
> .instance_size = sizeof(EduState),
> .instance_init = edu_instance_init,
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-14 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-14 5:11 [Qemu-devel] [PATCH] hw: edu: replace device name with macro Li Qiang
2018-09-14 15:09 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).