* [Qemu-devel] [PATCH] i440fx: use ARRAY_SIZE for pam_regions
@ 2018-10-11 12:14 Li Qiang
2018-10-11 12:18 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Li Qiang @ 2018-10-11 12:14 UTC (permalink / raw)
To: mst, marcel.apfelbaum; +Cc: qemu-devel, qemu-trivial, Li Qiang
Cc: qemu-trivial@nongnu.org
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
hw/pci-host/piix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e608347c1..230d5d2ea3 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -142,7 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
PCIDevice *pd = PCI_DEVICE(d);
memory_region_transaction_begin();
- for (i = 0; i < 13; i++) {
+ for (i = 0; i < ARRAY_SIZE(d->pam_regions); i++) {
pam_update(&d->pam_regions[i], i,
pd->config[I440FX_PAM + (DIV_ROUND_UP(i, 2))]);
}
@@ -401,7 +401,7 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type,
init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
&f->pam_regions[0], PAM_BIOS_BASE, PAM_BIOS_SIZE);
- for (i = 0; i < 12; ++i) {
+ for (i = 0; i < ARRAY_SIZE(f->pam_regions) - 1; ++i) {
init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
&f->pam_regions[i+1], PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE,
PAM_EXPAN_SIZE);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] i440fx: use ARRAY_SIZE for pam_regions
2018-10-11 12:14 [Qemu-devel] [PATCH] i440fx: use ARRAY_SIZE for pam_regions Li Qiang
@ 2018-10-11 12:18 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-11 12:18 UTC (permalink / raw)
To: Li Qiang, mst, marcel.apfelbaum; +Cc: qemu-trivial, qemu-devel
On 11/10/2018 14:14, Li Qiang wrote:
> Cc: qemu-trivial@nongnu.org
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
Good cleanup!
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/pci-host/piix.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..230d5d2ea3 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -142,7 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
> PCIDevice *pd = PCI_DEVICE(d);
>
> memory_region_transaction_begin();
> - for (i = 0; i < 13; i++) {
> + for (i = 0; i < ARRAY_SIZE(d->pam_regions); i++) {
> pam_update(&d->pam_regions[i], i,
> pd->config[I440FX_PAM + (DIV_ROUND_UP(i, 2))]);
> }
> @@ -401,7 +401,7 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type,
>
> init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
> &f->pam_regions[0], PAM_BIOS_BASE, PAM_BIOS_SIZE);
> - for (i = 0; i < 12; ++i) {
> + for (i = 0; i < ARRAY_SIZE(f->pam_regions) - 1; ++i) {
> init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
> &f->pam_regions[i+1], PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE,
> PAM_EXPAN_SIZE);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 12:14 [Qemu-devel] [PATCH] i440fx: use ARRAY_SIZE for pam_regions Li Qiang
2018-10-11 12:18 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).