qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: Modern shell scripting (use $() instead of ``)
Date: Wed, 17 Oct 2018 12:05:01 +0200	[thread overview]
Message-ID: <1539770707-7289-10-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1539770707-7289-1-git-send-email-thuth@redhat.com>

From: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>

Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/show-fixed-bugs.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/show-fixed-bugs.sh b/scripts/show-fixed-bugs.sh
index 36f3068..a095a4d 100755
--- a/scripts/show-fixed-bugs.sh
+++ b/scripts/show-fixed-bugs.sh
@@ -23,10 +23,10 @@ while getopts "s:e:cbh" opt; do
 done
 
 if [ "x$start" = "x" ]; then
-    start=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1`
+    start=$(git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1)
 fi
 if [ "x$end" = "x" ]; then
-    end=`git tag -l  'v[0-9]*\.[0-9]*\.0' | tail -n 1`
+    end=$(git tag -l  'v[0-9]*\.[0-9]*\.0' | tail -n 1)
 fi
 
 if [ "x$start" = "x" ] || [ "x$end" = "x" ]; then
@@ -38,9 +38,9 @@ fi
 echo "Searching git log for bugs in the range $start..$end"
 
 urlstr='https://bugs.launchpad.net/\(bugs\|qemu/+bug\)/'
-bug_urls=`git log $start..$end \
+bug_urls=$(git log $start..$end \
   | sed -n '\,'"$urlstr"', s,\(.*\)\('"$urlstr"'\)\([0-9]*\).*,\2\4,p' \
-  | sort -u`
+  | sort -u)
 
 echo Found bug URLs:
 for i in $bug_urls ; do echo " $i" ; done
@@ -68,7 +68,7 @@ elif [ "x$show_in_browser" = "x1" ]; then
         bugbrowser=xdg-open
     elif command -v gnome-open >/dev/null 2>&1; then
         bugbrowser=gnome-open
-    elif [ "`uname`" = "Darwin" ]; then
+    elif [ "$(uname)" = "Darwin" ]; then
         bugbrowser=open
     elif command -v sensible-browser >/dev/null 2>&1; then
         bugbrowser=sensible-browser
-- 
1.8.3.1

  parent reply	other threads:[~2018-10-17 10:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17 10:04 [Qemu-devel] [PULL 00/15] qtest and misc patches Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 01/15] qemu-common.h: update copyright date to 2018 Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_separate() Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 03/15] tests: Prevent more accidental test disabling Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 04/15] tests: remove gcov-files- variables Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 05/15] gdbstub: Remove unused include Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 06/15] MAINTAINERS: update block/sheepdog maintainers Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 07/15] archive-source.sh: Modern shell scripting (use $() instead of ``) Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 08/15] git-submodule.sh: " Thomas Huth
2018-10-17 10:05 ` Thomas Huth [this message]
2018-10-17 10:05 ` [Qemu-devel] [PULL 10/15] mailmap: Fix Reimar Döffinger name Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 11/15] qemu/compiler: Wrap __attribute__((flatten)) in a macro Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 12/15] hw/core/generic-loader: Set a category for the generic-loader device Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 13/15] cpu: Provide a proper prototype for target_words_bigendian() in a header Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not for each target Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 15/15] configure: remove glib_subprocess check Thomas Huth
2018-10-18 14:43 ` [Qemu-devel] [PULL 00/15] qtest and misc patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539770707-7289-10-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).