From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 07/15] archive-source.sh: Modern shell scripting (use $() instead of ``)
Date: Wed, 17 Oct 2018 12:04:59 +0200 [thread overview]
Message-ID: <1539770707-7289-8-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1539770707-7289-1-git-send-email-thuth@redhat.com>
From: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/archive-source.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh
index 4e63774..62bd225 100755
--- a/scripts/archive-source.sh
+++ b/scripts/archive-source.sh
@@ -18,7 +18,7 @@ if test $# -lt 1; then
error "Usage: $0 <output tarball>"
fi
-tar_file=`realpath "$1"`
+tar_file=$(realpath "$1")
list_file="${tar_file}.list"
vroot_dir="${tar_file}.vroot"
@@ -34,7 +34,7 @@ if git diff-index --quiet HEAD -- &>/dev/null
then
HEAD=HEAD
else
- HEAD=`git stash create`
+ HEAD=$(git stash create)
fi
git clone --shared . "$vroot_dir"
test $? -ne 0 && error "failed to clone into '$vroot_dir'"
--
1.8.3.1
next prev parent reply other threads:[~2018-10-17 10:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:04 [Qemu-devel] [PULL 00/15] qtest and misc patches Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 01/15] qemu-common.h: update copyright date to 2018 Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_separate() Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 03/15] tests: Prevent more accidental test disabling Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 04/15] tests: remove gcov-files- variables Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 05/15] gdbstub: Remove unused include Thomas Huth
2018-10-17 10:04 ` [Qemu-devel] [PULL 06/15] MAINTAINERS: update block/sheepdog maintainers Thomas Huth
2018-10-17 10:04 ` Thomas Huth [this message]
2018-10-17 10:05 ` [Qemu-devel] [PULL 08/15] git-submodule.sh: Modern shell scripting (use $() instead of ``) Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: " Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 10/15] mailmap: Fix Reimar Döffinger name Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 11/15] qemu/compiler: Wrap __attribute__((flatten)) in a macro Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 12/15] hw/core/generic-loader: Set a category for the generic-loader device Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 13/15] cpu: Provide a proper prototype for target_words_bigendian() in a header Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not for each target Thomas Huth
2018-10-17 10:05 ` [Qemu-devel] [PULL 15/15] configure: remove glib_subprocess check Thomas Huth
2018-10-18 14:43 ` [Qemu-devel] [PULL 00/15] qtest and misc patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539770707-7289-8-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).