From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG6TU-0000eo-Gn for qemu-devel@nongnu.org; Fri, 26 Oct 2018 14:04:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG6TR-0007TK-AM for qemu-devel@nongnu.org; Fri, 26 Oct 2018 14:04:44 -0400 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:35634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gG6TR-0007QI-2E for qemu-devel@nongnu.org; Fri, 26 Oct 2018 14:04:41 -0400 Received: by mail-qt1-x841.google.com with SMTP id a10-v6so2250780qtp.2 for ; Fri, 26 Oct 2018 11:04:35 -0700 (PDT) From: Dayeol Lee Date: Fri, 26 Oct 2018 18:04:27 +0000 Message-Id: <1540577067-8235-1-git-send-email-dayeol@berkeley.edu> Subject: [Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dayeol Lee , Michael Clark , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann pmp_read_cfg() returns 8-bit value, which is combined together to form a single pmpcfg CSR. The default promotion rules will result in an integer here ("i*8" is integer, which flows through) resulting in a 32-bit signed value on most hosts. That's bogus on RV64I, with the high bits of the CSR being wrong. Signed-off-by: Dayeol Lee Reviewed-by: Palmer Dabbelt --- target/riscv/pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index c828950..3d3906a 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -330,7 +330,7 @@ target_ulong pmpcfg_csr_read(CPURISCVState *env, uint32_t reg_index) { int i; target_ulong cfg_val = 0; - uint8_t val = 0; + target_ulong val = 0; if(sizeof(target_ulong) == 8) reg_index /= 2; -- 2.7.4