qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Clement Deschamps <clement.deschamps@greensocs.com>
Subject: [Qemu-devel] [PULL 01/10] icount: fix deadlock when all cpus are sleeping
Date: Tue, 30 Oct 2018 20:50:02 +0100	[thread overview]
Message-ID: <1540929011-19894-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1540929011-19894-1-git-send-email-pbonzini@redhat.com>

From: Clement Deschamps <clement.deschamps@greensocs.com>

When all cpus are sleeping (e.g in WFI), to avoid a deadlock
in the main_loop, wake it up in order to start the warp timer.

Signed-off-by: Clement Deschamps <clement.deschamps@greensocs.com>
Message-Id: <20181021142103.19014-1-clement.deschamps@greensocs.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 cpus.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/cpus.c b/cpus.c
index 3978f63..a2b33cc 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1554,6 +1554,14 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)
             atomic_mb_set(&cpu->exit_request, 0);
         }
 
+        if (use_icount && all_cpu_threads_idle()) {
+            /*
+             * When all cpus are sleeping (e.g in WFI), to avoid a deadlock
+             * in the main_loop, wake it up in order to start the warp timer.
+             */
+            qemu_notify_event();
+        }
+
         qemu_tcg_rr_wait_io_event(cpu ? cpu : first_cpu);
         deal_with_unplugged_cpus();
     }
-- 
1.8.3.1

  reply	other threads:[~2018-10-30 19:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 19:50 [Qemu-devel] [PULL 00/10] Misc patches for 2018-10-30 Paolo Bonzini
2018-10-30 19:50 ` Paolo Bonzini [this message]
2018-10-30 19:50 ` [Qemu-devel] [PULL 02/10] x86: hv_evmcs CPU flag support Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 03/10] i386: clarify that the Q35 machine type implements a P35 chipset Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 04/10] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 05/10] target/i386: Clear RF on SYSCALL instruction Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 06/10] memory: learn about non-volatile memory region Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 07/10] nvdimm: set non-volatile on the " Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 08/10] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList Paolo Bonzini
2018-11-05 15:37   ` Laszlo Ersek
2018-11-06 10:04     ` Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 09/10] scripts/dump-guest-memory: Synchronize with guest_phys_blocks_region_add Paolo Bonzini
2018-11-05 15:46   ` Laszlo Ersek
2018-11-06 10:06     ` Paolo Bonzini
2018-10-30 19:50 ` [Qemu-devel] [PULL 10/10] lsi53c895a: check message length value is valid Paolo Bonzini
2018-11-01 12:06 ` [Qemu-devel] [PULL 00/10] Misc patches for 2018-10-30 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1540929011-19894-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=clement.deschamps@greensocs.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).