From: Li Qiang <liq3ea@gmail.com>
To: eblake@redhat.com, armbru@redhat.com
Cc: qemu-devel@nongnu.org, Li Qiang <liq3ea@gmail.com>
Subject: [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo
Date: Fri, 2 Nov 2018 04:01:03 -0700 [thread overview]
Message-ID: <1541156463-2730-1-git-send-email-liq3ea@gmail.com> (raw)
When trigger a 'query-cpus' qmp, the pc is an signed value like
following:
{"arch": "x86", ... "pc": -1732653994, "halted": true,...}
It is strange. Change it to uint64_t.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
qapi/misc.json | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index 6c1c5c0a37..621ec6ce13 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -407,7 +407,7 @@
#
# Since: 2.6
##
-{ 'struct': 'CpuInfoX86', 'data': { 'pc': 'int' } }
+{ 'struct': 'CpuInfoX86', 'data': { 'pc': 'uint64' } }
##
# @CpuInfoSPARC:
@@ -420,7 +420,7 @@
#
# Since: 2.6
##
-{ 'struct': 'CpuInfoSPARC', 'data': { 'pc': 'int', 'npc': 'int' } }
+{ 'struct': 'CpuInfoSPARC', 'data': { 'pc': 'uint64', 'npc': 'uint64' } }
##
# @CpuInfoPPC:
@@ -431,7 +431,7 @@
#
# Since: 2.6
##
-{ 'struct': 'CpuInfoPPC', 'data': { 'nip': 'int' } }
+{ 'struct': 'CpuInfoPPC', 'data': { 'nip': 'uint64' } }
##
# @CpuInfoMIPS:
@@ -442,7 +442,7 @@
#
# Since: 2.6
##
-{ 'struct': 'CpuInfoMIPS', 'data': { 'PC': 'int' } }
+{ 'struct': 'CpuInfoMIPS', 'data': { 'PC': 'uint64' } }
##
# @CpuInfoTricore:
@@ -453,7 +453,7 @@
#
# Since: 2.6
##
-{ 'struct': 'CpuInfoTricore', 'data': { 'PC': 'int' } }
+{ 'struct': 'CpuInfoTricore', 'data': { 'PC': 'uint64' } }
##
# @CpuInfoRISCV:
@@ -464,7 +464,7 @@
#
# Since 2.12
##
-{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'int' } }
+{ 'struct': 'CpuInfoRISCV', 'data': { 'pc': 'uint64' } }
##
# @CpuS390State:
--
2.11.0
next reply other threads:[~2018-11-02 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 11:01 Li Qiang [this message]
2018-11-05 23:01 ` [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo Eric Blake
2018-11-29 15:38 ` [Qemu-devel] QAPI 'size' vs. 'uint64' (was: [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo) Markus Armbruster
2018-11-06 9:11 ` [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541156463-2730-1-git-send-email-liq3ea@gmail.com \
--to=liq3ea@gmail.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).