* [Qemu-devel] [PATCH] target: hax: fix a typo
@ 2018-11-26 9:58 Li Qiang
2018-11-26 11:51 ` Alex Bennée
2018-11-28 12:43 ` Paolo Bonzini
0 siblings, 2 replies; 7+ messages in thread
From: Li Qiang @ 2018-11-26 9:58 UTC (permalink / raw)
To: pbonzini, rth, ehabkost, laurent; +Cc: qemu-devel, qemu-trivial, Li Qiang
Cc: qemu-trivial@nongnu.org
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
target/i386/hax-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index 502ce6f0af..464744a406 100644
--- a/target/i386/hax-all.c
+++ b/target/i386/hax-all.c
@@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
}
/*
- * 1. The hax_tunnel is also destroied when vcpu destroy
+ * 1. The hax_tunnel is also destroyed when vcpu destroy
* 2. close fd will cause hax module vcpu be cleaned
*/
hax_close_fd(vcpu->fd);
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] target: hax: fix a typo
2018-11-26 9:58 [Qemu-devel] [PATCH] target: hax: fix a typo Li Qiang
@ 2018-11-26 11:51 ` Alex Bennée
2018-11-26 21:25 ` Philippe Mathieu-Daudé
2018-11-28 12:43 ` Paolo Bonzini
1 sibling, 1 reply; 7+ messages in thread
From: Alex Bennée @ 2018-11-26 11:51 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, rth, ehabkost, laurent, qemu-trivial, Li Qiang
Li Qiang <liq3ea@gmail.com> writes:
> Cc: qemu-trivial@nongnu.org
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/i386/hax-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index 502ce6f0af..464744a406 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
> }
>
> /*
> - * 1. The hax_tunnel is also destroied when vcpu destroy
> + * 1. The hax_tunnel is also destroyed when vcpu destroy
> * 2. close fd will cause hax module vcpu be cleaned
> */
> hax_close_fd(vcpu->fd);
--
Alex Bennée
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target: hax: fix a typo
2018-11-26 11:51 ` Alex Bennée
@ 2018-11-26 21:25 ` Philippe Mathieu-Daudé
2018-11-26 21:33 ` Richard Henderson
0 siblings, 1 reply; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-26 21:25 UTC (permalink / raw)
To: Alex Bennée, qemu-devel, Li Qiang
Cc: ehabkost, qemu-trivial, laurent, pbonzini, rth
Hi Li, Alex.
On 26/11/18 12:51, Alex Bennée wrote:
>
> Li Qiang <liq3ea@gmail.com> writes:
>
>> Cc: qemu-trivial@nongnu.org
>>
>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
>> ---
>> target/i386/hax-all.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>> index 502ce6f0af..464744a406 100644
>> --- a/target/i386/hax-all.c
>> +++ b/target/i386/hax-all.c
>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>> }
>>
>> /*
>> - * 1. The hax_tunnel is also destroied when vcpu destroy
>> + * 1. The hax_tunnel is also destroyed when vcpu destroy
I'm not native english speaker. Isn't it:
'The hax_tunnel is also destroyed at vcpu destroy'
or
'The hax_tunnel is also destroyed when vcpu is destroyed'?
>> * 2. close fd will cause hax module vcpu be cleaned
>> */
>> hax_close_fd(vcpu->fd);
>
>
> --
> Alex Bennée
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target: hax: fix a typo
2018-11-26 21:25 ` Philippe Mathieu-Daudé
@ 2018-11-26 21:33 ` Richard Henderson
0 siblings, 0 replies; 7+ messages in thread
From: Richard Henderson @ 2018-11-26 21:33 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Alex Bennée, qemu-devel,
Li Qiang
Cc: ehabkost, qemu-trivial, laurent, pbonzini
On 11/26/18 1:25 PM, Philippe Mathieu-Daudé wrote:
>>> - * 1. The hax_tunnel is also destroied when vcpu destroy
>>> + * 1. The hax_tunnel is also destroyed when vcpu destroy
> I'm not native english speaker. Isn't it:
>
> 'The hax_tunnel is also destroyed at vcpu destroy'
>
> or
>
> 'The hax_tunnel is also destroyed when vcpu is destroyed'?
This second option is best, fwiw.
r~
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target: hax: fix a typo
2018-11-26 9:58 [Qemu-devel] [PATCH] target: hax: fix a typo Li Qiang
2018-11-26 11:51 ` Alex Bennée
@ 2018-11-28 12:43 ` Paolo Bonzini
2018-11-28 12:47 ` Laurent Vivier
1 sibling, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2018-11-28 12:43 UTC (permalink / raw)
To: Li Qiang, rth, ehabkost, laurent; +Cc: qemu-devel, qemu-trivial
On 26/11/18 10:58, Li Qiang wrote:
> Cc: qemu-trivial@nongnu.org
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> target/i386/hax-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index 502ce6f0af..464744a406 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
> }
>
> /*
> - * 1. The hax_tunnel is also destroied when vcpu destroy
> + * 1. The hax_tunnel is also destroyed when vcpu destroy
> * 2. close fd will cause hax module vcpu be cleaned
> */
> hax_close_fd(vcpu->fd);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target: hax: fix a typo
2018-11-28 12:43 ` Paolo Bonzini
@ 2018-11-28 12:47 ` Laurent Vivier
2018-11-28 13:03 ` Paolo Bonzini
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Vivier @ 2018-11-28 12:47 UTC (permalink / raw)
To: Paolo Bonzini, Li Qiang, rth, ehabkost; +Cc: qemu-devel, qemu-trivial
Le 28/11/2018 à 13:43, Paolo Bonzini a écrit :
> On 26/11/18 10:58, Li Qiang wrote:
>> Cc: qemu-trivial@nongnu.org
>>
>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
>> ---
>> target/i386/hax-all.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>> index 502ce6f0af..464744a406 100644
>> --- a/target/i386/hax-all.c
>> +++ b/target/i386/hax-all.c
>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>> }
>>
>> /*
>> - * 1. The hax_tunnel is also destroied when vcpu destroy
>> + * 1. The hax_tunnel is also destroyed when vcpu destroy
>> * 2. close fd will cause hax module vcpu be cleaned
>> */
>> hax_close_fd(vcpu->fd);
>>
>
> Queued, thanks.
>
There is a v2: "target: hax: fix errors in comment" with "vcpu is
destroyed" rather than "vcpu destroy".
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] target: hax: fix a typo
2018-11-28 12:47 ` Laurent Vivier
@ 2018-11-28 13:03 ` Paolo Bonzini
0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2018-11-28 13:03 UTC (permalink / raw)
To: Laurent Vivier, Li Qiang, rth, ehabkost; +Cc: qemu-devel, qemu-trivial
On 28/11/18 13:47, Laurent Vivier wrote:
> Le 28/11/2018 à 13:43, Paolo Bonzini a écrit :
>> On 26/11/18 10:58, Li Qiang wrote:
>>> Cc: qemu-trivial@nongnu.org
>>>
>>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
>>> ---
>>> target/i386/hax-all.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>>> index 502ce6f0af..464744a406 100644
>>> --- a/target/i386/hax-all.c
>>> +++ b/target/i386/hax-all.c
>>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>>> }
>>>
>>> /*
>>> - * 1. The hax_tunnel is also destroied when vcpu destroy
>>> + * 1. The hax_tunnel is also destroyed when vcpu destroy
>>> * 2. close fd will cause hax module vcpu be cleaned
>>> */
>>> hax_close_fd(vcpu->fd);
>>>
>>
>> Queued, thanks.
>>
>
> There is a v2: "target: hax: fix errors in comment" with "vcpu is
> destroyed" rather than "vcpu destroy".
>
> Thanks,
> Laurent
>
Got it---I'll adjust my filter to hide qemu-trivial patches. :)
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-28 13:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-26 9:58 [Qemu-devel] [PATCH] target: hax: fix a typo Li Qiang
2018-11-26 11:51 ` Alex Bennée
2018-11-26 21:25 ` Philippe Mathieu-Daudé
2018-11-26 21:33 ` Richard Henderson
2018-11-28 12:43 ` Paolo Bonzini
2018-11-28 12:47 ` Laurent Vivier
2018-11-28 13:03 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).