From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gReTx-0003nm-AA for qemu-devel@nongnu.org; Tue, 27 Nov 2018 09:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gReTt-0001TD-Dz for qemu-devel@nongnu.org; Tue, 27 Nov 2018 09:36:57 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:35989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gReTt-0001Qg-7a for qemu-devel@nongnu.org; Tue, 27 Nov 2018 09:36:53 -0500 Received: by mail-wr1-x42d.google.com with SMTP id t3so22937214wrr.3 for ; Tue, 27 Nov 2018 06:36:53 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 27 Nov 2018 15:36:28 +0100 Message-Id: <1543329397-48407-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1543329397-48407-1-git-send-email-pbonzini@redhat.com> References: <1543329397-48407-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 06/15] vl: Improve error message when we can't load fw_cfg from file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Li Qiang From: Li Qiang parse_fw_cfg() reports "can't load" without further details. Get the details from g_file_get_contents(), and include them in the error message. Signed-off-by: Li Qiang Message-Id: <1541051971-28584-1-git-send-email-liq3ea@gmail.com> Signed-off-by: Paolo Bonzini --- vl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index d6fd95c..611d887 100644 --- a/vl.c +++ b/vl.c @@ -2250,8 +2250,10 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp) size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */ buf = g_memdup(str, size); } else { - if (!g_file_get_contents(file, &buf, &size, NULL)) { - error_setg(errp, "can't load %s", file); + GError *err = NULL; + if (!g_file_get_contents(file, &buf, &size, &err)) { + error_setg(errp, "can't load %s: %s", file, err->message); + g_error_free(err); return -1; } } -- 1.8.3.1