From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Geoffrey McRae <geoff@hostfission.com>
Subject: [Qemu-devel] [for-3.2 PATCH 7/9] vfio/pci: Remove PCIe Link Status emulation
Date: Fri, 30 Nov 2018 17:14:37 -0700 [thread overview]
Message-ID: <154362327698.7153.13628818975843977058.stgit@gimli.home> (raw)
In-Reply-To: <154362272919.7153.15101701755308287523.stgit@gimli.home>
Now that the downstream port will virtually negotiate itself to the
link status of the downstream devie, we can remove this emulation.
It's not clear that it was every terribly useful anyway.
Tested-by: Geoffrey McRae <geoff@hostfission.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/vfio/pci.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 74f9a46b4be0..c0cb1ec28908 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1901,12 +1901,6 @@ static int vfio_setup_pcie_cap(VFIOPCIDevice *vdev, int pos, uint8_t size,
QEMU_PCI_EXP_LNKCAP_MLS(QEMU_PCI_EXP_LNK_2_5GT), ~0);
vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKCTL, 0, ~0);
}
-
- /* Mark the Link Status bits as emulated to allow virtual negotiation */
- vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKSTA,
- pci_get_word(vdev->pdev.config + pos +
- PCI_EXP_LNKSTA),
- PCI_EXP_LNKCAP_MLW | PCI_EXP_LNKCAP_SLS);
}
/*
next prev parent reply other threads:[~2018-12-01 0:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 0:13 [Qemu-devel] [for-3.2 PATCH 0/9] pcie: Enhanced link speed and width support Alex Williamson
2018-12-01 0:13 ` [Qemu-devel] [for-3.2 PATCH 1/9] pcie: Create enums for link speed and width Alex Williamson
2018-12-01 0:13 ` [Qemu-devel] [for-3.2 PATCH 2/9] pci: Sync PCIe downstream port LNKSTA on read Alex Williamson
2018-12-01 0:13 ` [Qemu-devel] [for-3.2 PATCH 3/9] qapi: Define PCIe link speed and width properties Alex Williamson
2018-12-01 0:14 ` [Qemu-devel] [for-3.2 PATCH 4/9] pcie: Add link speed and width fields to PCIESlot Alex Williamson
2018-12-01 0:14 ` [Qemu-devel] [for-3.2 PATCH 5/9] pcie: Fill PCIESlot link fields to support higher speeds and widths Alex Williamson
2018-12-01 0:14 ` [Qemu-devel] [for-3.2 PATCH 6/9] pcie: Allow generic PCIe root port to specify link speed and width Alex Williamson
2018-12-01 0:14 ` Alex Williamson [this message]
2018-12-01 0:14 ` [Qemu-devel] [for-3.2 PATCH 8/9] q35/440fx/arm/spapr: Add QEMU 3.2 machine type Alex Williamson
2018-12-01 11:49 ` Peter Maydell
2018-12-01 0:14 ` [Qemu-devel] [for-3.2 PATCH 9/9] pcie: Fast PCIe root ports for new machines Alex Williamson
2018-12-01 11:38 ` [Qemu-devel] [for-3.2 PATCH 0/9] pcie: Enhanced link speed and width support Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154362327698.7153.13628818975843977058.stgit@gimli.home \
--to=alex.williamson@redhat.com \
--cc=geoff@hostfission.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).