From: Wei Wang <wei.w.wang@intel.com>
To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
peterx@redhat.com
Cc: pbonzini@redhat.com, liliang.opensource@gmail.com,
nilal@redhat.com, riel@redhat.com, wei.w.wang@intel.com
Subject: [Qemu-devel] [PATCH v10 0/7] virtio-balloon: free page hint support
Date: Mon, 3 Dec 2018 10:18:24 +0800 [thread overview]
Message-ID: <1543803511-34793-1-git-send-email-wei.w.wang@intel.com> (raw)
This is the deivce part implementation to add a new feature,
VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device
receives the guest free page hints from the driver and clears the
corresponding bits in the dirty bitmap, so that those free pages are
not sent by the migration thread to the destination.
*Tests
1 Test Environment
Host: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
Migration setup: migrate_set_speed 100G, migrate_set_downtime 400ms
2 Test Results (results are averaged over several repeated runs)
2.1 Guest setup: 8G RAM, 4 vCPU
2.1.1 Idle guest live migration time
Optimization v.s. Legacy = 620ms vs 2970ms
--> ~79% reduction
2.1.2 Guest live migration with Linux compilation workload
(i.e. make bzImage -j4) running
1) Live Migration Time:
Optimization v.s. Legacy = 2273ms v.s. 4502ms
--> ~50% reduction
2) Linux Compilation Time:
Optimization v.s. Legacy = 8min42s v.s. 8min43s
--> no obvious difference
2.2 Guest setup: 128G RAM, 4 vCPU
2.2.1 Idle guest live migration time
Optimization v.s. Legacy = 5294ms vs 41651ms
--> ~87% reduction
2.2.2 Guest live migration with Linux compilation workload
1) Live Migration Time:
Optimization v.s. Legacy = 8816ms v.s. 54201ms
--> 84% reduction
2) Linux Compilation Time:
Optimization v.s. Legacy = 8min30s v.s. 8min36s
--> no obvious difference
ChangeLog:
v9->v10:
migration:
- qemu_guest_free_page_hint:
- move "addr += used_len" to the for() loop;
- add some comments about the ram block resize case.
- precopy notifier:
- enable callbacks to report errors (as the postcopy notifier);
- rename the notifier reasons:
- PRECOPY_NOTIFY_COMPLETE notifies the callback about the
end of precopy;
- PRECOPY_NOTIFY_CLEANUP notifies the callback in the case
migration is cancelled;
- relocate some notifications to the upper layer functions
(i.e. qemu_savevm_state_*), which can get the callbacks notified
when non-ram-saving code has errors which stops the precopy.
- migration_bitmap_sync_precopy to be called by the precopy code path
with precopy notifier supported, and migration_bitmap_sync is left
for callers without the need of precopy notifier (e.g. some postcopy
code).
- avoid exposing migrate_postcopy;
virtio-balloon:
- virtio_balloon_free_page_report_notify: remove the migrate_postcopy
check becasue the migration code has guaranteed that the notifier
callback is invoked when in the precopy mode.
Previous changelog:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg02854.html
Wei Wang (7):
bitmap: fix bitmap_count_one
bitmap: bitmap_count_one_with_offset
migration: use bitmap_mutex in migration_bitmap_clear_dirty
migration: API to clear bits of guest free pages from the dirty bitmap
migration/ram.c: add a notifier chain for precopy
migration/ram.c: add a function to disable the bulk stage
virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
hw/virtio/virtio-balloon.c | 263 ++++++++++++++++++++++++
include/hw/virtio/virtio-balloon.h | 28 ++-
include/migration/misc.h | 22 ++
include/qemu/bitmap.h | 17 ++
include/standard-headers/linux/virtio_balloon.h | 5 +
migration/ram.c | 112 +++++++++-
migration/savevm.c | 15 ++
vl.c | 1 +
8 files changed, 458 insertions(+), 5 deletions(-)
--
1.8.3.1
next reply other threads:[~2018-12-03 2:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 2:18 Wei Wang [this message]
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 1/7] bitmap: fix bitmap_count_one Wei Wang
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 2/7] bitmap: bitmap_count_one_with_offset Wei Wang
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 3/7] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang
2018-12-03 5:08 ` Peter Xu
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 4/7] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang
2018-12-03 5:10 ` Peter Xu
2018-12-03 8:07 ` Wei Wang
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 5/7] migration/ram.c: add a notifier chain for precopy Wei Wang
2018-12-03 5:20 ` Peter Xu
2018-12-03 8:10 ` Wei Wang
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 6/7] migration/ram.c: add a function to disable the bulk stage Wei Wang
2018-12-03 5:31 ` Peter Xu
2018-12-03 8:20 ` Wei Wang
2018-12-03 8:24 ` [Qemu-devel] [virtio-dev] " Wei Wang
2018-12-03 2:18 ` [Qemu-devel] [PATCH v10 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543803511-34793-1-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=dgilbert@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).