From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <rth@twiddle.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
pbonzini@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH for-4.0 v2 6/7] includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"
Date: Tue, 4 Dec 2018 16:32:56 +0100 [thread overview]
Message-ID: <1543937577-28256-7-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1543937577-28256-1-git-send-email-thuth@redhat.com>
Since we require GCC version 4.8 or newer now, we can be sure that
the builtin functions are always available on GCC. And for Clang,
we can check the availablility with __has_builtin instead.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/qemu/compiler.h | 2 +-
include/qemu/host-utils.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index 6b92710..1593bca 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -127,7 +127,7 @@
#define __has_builtin(x) 0 /* compatibility with non-clang compilers */
#endif
-#if __has_builtin(__builtin_assume_aligned) || QEMU_GNUC_PREREQ(4, 7)
+#if __has_builtin(__builtin_assume_aligned) || !defined(__clang__)
#define HAS_ASSUME_ALIGNED
#endif
diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h
index 38da849..4cd170e 100644
--- a/include/qemu/host-utils.h
+++ b/include/qemu/host-utils.h
@@ -207,7 +207,7 @@ static inline int cto64(uint64_t val)
*/
static inline int clrsb32(uint32_t val)
{
-#if QEMU_GNUC_PREREQ(4, 7)
+#if __has_builtin(__builtin_clrsb) || !defined(__clang__)
return __builtin_clrsb(val);
#else
return clz32(val ^ ((int32_t)val >> 1)) - 1;
@@ -223,7 +223,7 @@ static inline int clrsb32(uint32_t val)
*/
static inline int clrsb64(uint64_t val)
{
-#if QEMU_GNUC_PREREQ(4, 7)
+#if __has_builtin(__builtin_clrsbll) || !defined(__clang__)
return __builtin_clrsbll(val);
#else
return clz64(val ^ ((int64_t)val >> 1)) - 1;
--
1.8.3.1
next prev parent reply other threads:[~2018-12-04 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 15:32 [Qemu-devel] [PATCH for-4.0 v2 0/7] Assume GCC v4.8 and Clang v3.4 as minimum compiler Thomas Huth
2018-12-04 15:32 ` [Qemu-devel] [PATCH for-4.0 v2 1/7] configure: Add a test for the minimum compiler version Thomas Huth
2018-12-07 16:27 ` Richard Henderson
2018-12-04 15:32 ` [Qemu-devel] [PATCH for-4.0 v2 2/7] configure: Remove obsolete check for Clang < 3.2 Thomas Huth
2018-12-07 16:28 ` Richard Henderson
2018-12-04 15:32 ` [Qemu-devel] [PATCH for-4.0 v2 3/7] configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012] Thomas Huth
2018-12-12 8:54 ` Thomas Huth
2018-12-04 15:32 ` [Qemu-devel] [PATCH for-4.0 v2 4/7] tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro Thomas Huth
2018-12-04 15:32 ` [Qemu-devel] [PATCH for-4.0 v2 5/7] audio/alsaaudio: Remove compiler check around pragma Thomas Huth
2018-12-07 16:28 ` Richard Henderson
2018-12-04 15:32 ` Thomas Huth [this message]
2018-12-04 15:32 ` [Qemu-devel] [PATCH for-4.0 v2 7/7] Remove QEMU_ARTIFICIAL macro Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543937577-28256-7-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).