qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	eblake@redhat.com
Subject: [Qemu-devel] [PATCH for-4.0 5/5] tests/pxe: Make test independent from global_qtest
Date: Thu,  6 Dec 2018 17:49:58 +0100	[thread overview]
Message-ID: <1544114998-1513-6-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1544114998-1513-1-git-send-email-thuth@redhat.com>

global_qtest is not really required here, since boot_sector_test()
is already independent from that global variable.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/pxe-test.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/pxe-test.c b/tests/pxe-test.c
index 6e36796..73ac1d1 100644
--- a/tests/pxe-test.c
+++ b/tests/pxe-test.c
@@ -61,6 +61,7 @@ static testdef_t s390x_tests[] = {
 
 static void test_pxe_one(const testdef_t *test, bool ipv6)
 {
+    QTestState *qts;
     char *args;
 
     args = g_strdup_printf(
@@ -70,9 +71,9 @@ static void test_pxe_one(const testdef_t *test, bool ipv6)
         test->machine, disk, ipv6 ? "off" : "on", ipv6 ? "on" : "off",
         test->model);
 
-    qtest_start(args);
-    boot_sector_test(global_qtest);
-    qtest_quit(global_qtest);
+    qts = qtest_init(args);
+    boot_sector_test(qts);
+    qtest_quit(qts);
     g_free(args);
 }
 
-- 
1.8.3.1

  parent reply	other threads:[~2018-12-06 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 16:49 [Qemu-devel] [PATCH for-4.0 0/5] Make more tests independent of global_qtest Thomas Huth
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 1/5] tests/boot-serial: Get rid of global_qtest variable Thomas Huth
2018-12-06 18:42   ` Eric Blake
2018-12-06 19:34     ` Thomas Huth
2018-12-06 19:56       ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 2/5] tests/test-filter: Make tests independent of global_qtest Thomas Huth
2018-12-06 18:43   ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 3/5] tests/machine-none: Make test " Thomas Huth
2018-12-06 18:44   ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 4/5] tests/prom-env: " Thomas Huth
2018-12-06 18:46   ` Eric Blake
2018-12-06 16:49 ` Thomas Huth [this message]
2018-12-06 18:50   ` [Qemu-devel] [PATCH for-4.0 5/5] tests/pxe: Make test independent from global_qtest Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544114998-1513-6-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).